krytarowski added a comment.
OK to land it? FreeBSD can reuse almost exact the same code. I'm not sure if
it's compatible with their Process Plugin.
Repository:
rL LLVM
https://reviews.llvm.org/D29266
___
lldb-commits mailing list
lldb-commits@l
krytarowski updated this revision to Diff 87126.
krytarowski added a comment.
Catch up after r294114 - Clean up PlatformLinux code
Repository:
rL LLVM
https://reviews.llvm.org/D29266
Files:
source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp
source/Plugins/Platform/NetBSD/PlatformNetBSD.h
krytarowski added a comment.
I'm syncing the code to get the changes from SVN revision 294114 "Clean up
PlatformLinux code"
Repository:
rL LLVM
https://reviews.llvm.org/D29266
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://list
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Just sync once more please and I think we're done. We've removed enough code to
offset the remaining bit of duplication here. DebugProcess is the only
remaining candidate for merging, but we d
krytarowski updated this revision to Diff 87102.
krytarowski added a comment.
Sync this patch with SVN 294071.
It is to be used at least for a reference in further code sharing.
Repository:
rL LLVM
https://reviews.llvm.org/D29266
Files:
source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp
krytarowski added a comment.
I need to finish three patches:
- llvm::call_once,
- auxv reading,
- six.py conflict removal
and I will join here.
After that, I will switch the PT_WATCHPOINT* interface to PT_GETDBREGS and
PT_SETDBREGS -- and in the end, add dbregs support in NetBSD's userdata. La
krytarowski added a comment.
In https://reviews.llvm.org/D29266#661839, @labath wrote:
> After looking at this closer, I don't think we will even need a separate
> class to achieve deduplication. The code is so heavily duplicated (see
> comments on the first three non-boilerplate functions, I d
labath added a comment.
After looking at this closer, I don't think we will even need a separate class
to achieve deduplication. The code is so heavily duplicated (see comments on
the first three non-boilerplate functions, I did not look at the rest yet, but
I expect the situation to be the sam
krytarowski added a comment.
Diff
diff -u source/Plugins/Platform/Linux/PlatformLinux.cpp
source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp
Mostly everything is the same for now.
--- source/Plugins/Platform/Linux/PlatformLinux.cpp 2016-12-19
17:48:18.156356172 +0100
+++ source/Plugins/P
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
How much of the code is now actually different between the two classes? If the
only changes are of the s/linux/netbsd type, then we should just create a new
base class for the two, a
krytarowski created this revision.
krytarowski added a project: LLDB.
Update the code to the new world code.
These changes are needed for remote process plugin.
Sponsored by
Repository:
rL LLVM
https://reviews.llvm.org/D29266
Files:
source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp
so
11 matches
Mail list logo
