This revision was automatically updated to reflect the committed changes.
Closed by commit rL294415: [LLDB][MIPS] Fix TestMiniDumpNew (authored by
nitesh.jain).
Changed prior to commit:
https://reviews.llvm.org/D29215?vs=86268&id=87598#toc
Repository:
rL LLVM
https://reviews.llvm.org/D29215
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
I am glad we could come closer to the cause of the problem. At one point we
should have a common base class for all core tests, so that we don't have to do
this manually (and also avoid doing
nitesh.jain updated this revision to Diff 86268.
nitesh.jain added a comment.
Added setUp/tearDown code, which saves and restores the original platform after
each run. Thanks
https://reviews.llvm.org/D29215
Files:
packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMi
labath added a comment.
Ok, I've just checked and this does not happen on windows. It does however
happen (GetTriple() returning None) when we try to open the s390x core file
(functionalities/postmortem/elf-core/linux-s390x.out). The test suite seems to
be handling it fine.
The only difference
nitesh.jain added a comment.
ERROR: test_two_cores_same_pid (TestMiniDumpNew.MiniDumpNewTestCase)
Test that we handle the situation if we have two core files with the same PID
--
Traceback (most recent call last):
File
"/
nitesh.jain added a comment.
Hi Labath,
I think on window ur host architecture is x86_64 hence when
TargetList::CreateTargetInternal(..) is call, at line 269 the code is
if (!prefer_platform_arch && arch.IsValid()) {
if (!platform_sp->IsCompatibleArchitecture(arch, false, &platform_arch)
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
This seems like it's fixing the problem in the wrong place. Also, the
assumption that the platform == host_platform is not correct (what about when
the test is run on windows?)
I th
nitesh.jain created this revision.
In case of a core file, if the core file architecture(like x86_64) is
incompatible with that of Host architecture(like Mips64) then platform is set
to remote-platform. If the remote-platform is not connected then
SBPlatform::GetTriple() will return none. Hence
