This revision was automatically updated to reflect the committed changes.
Closed by commit rL290359: Fix a couple of incorrect format string warnings
(authored by ldrumm).
Changed prior to commit:
https://reviews.llvm.org/D28028?vs=82334&id=82354#toc
Repository:
rL LLVM
https://reviews.llvm
ldrumm updated this revision to Diff 82334.
ldrumm added a comment.
switched to the new llvm::Format API
https://reviews.llvm.org/D28028
Files:
source/Interpreter/Args.cpp
source/Plugins/ExpressionParser/Clang/IRForTarget.cpp
Index: source/Plugins/ExpressionParser/Clang/IRForTarget.cpp
==
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Please swift to using the new formatv stuff as this is the main reason Zach
made those changes.
Comment at: source/Plugins/ExpressionParser/Clang/IRForTarget.c
zturner added a comment.
How about re-writing these to use `llvm::formatv()` since the whole point of it
is to eliminate this problem entirely and clayborg@ has agreed that it looks
good going forward?
Individual call-site suggestions inlined.
Comment at: source/Interpreter/
ldrumm created this revision.
ldrumm added reviewers: zturner, clayborg.
ldrumm added a subscriber: LLDB.
This patch fixes use of incorrect `%zi` to format a plain `int`, and switches
from using "%llu" to format a uint64_t to using the exact width specifier
PRIu64 from inttypes.h
https://revie
