[Lldb-commits] [PATCH] D27459: Add a more succinct logging syntax

2017-01-18 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL292360: Add a more succinct logging syntax (authored by labath). Changed prior to commit: https://reviews.llvm.org/D27459?vs=84690&id=84814#toc Repository: rL LLVM https://reviews.llvm.org/D27459 F

[Lldb-commits] [PATCH] D27459: Add a more succinct logging syntax

2017-01-18 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: source/Core/Log.cpp:78 + char *text; + vasprintf(&text, format, args); + message << text; zturner wrote: > dancol wrote: > > I usually implement printf-into-std::string by using `vsnprintf` to figure > > out how many

[Lldb-commits] [PATCH] D27459: Add a more succinct logging syntax

2017-01-17 Thread Zachary Turner via Phabricator via lldb-commits
zturner added inline comments. Comment at: source/Core/Log.cpp:78 + char *text; + vasprintf(&text, format, args); + message << text; dancol wrote: > I usually implement printf-into-std::string by using `vsnprintf` to figure > out how many characters we genera

[Lldb-commits] [PATCH] D27459: Add a more succinct logging syntax

2017-01-17 Thread Daniel Colascione via Phabricator via lldb-commits
dancol added inline comments. Comment at: source/Core/Log.cpp:78 + char *text; + vasprintf(&text, format, args); + message << text; I usually implement printf-into-std::string by using `vsnprintf` to figure out how many characters we generate, using `std::str

[Lldb-commits] [PATCH] D27459: Add a more succinct logging syntax

2017-01-17 Thread Greg Clayton via Phabricator via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. https://reviews.llvm.org/D27459 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l