This revision was automatically updated to reflect the committed changes.
Closed by commit rL288494: Replace __ANDROID_NDK__ with __ANDROID__ (authored
by labath).
Changed prior to commit:
https://reviews.llvm.org/D27305?vs=80047&id=80048#toc
Repository:
rL LLVM
https://reviews.llvm.org/D27
labath updated this revision to Diff 80047.
labath added a comment.
A bit more cleanup.
https://reviews.llvm.org/D27305
Files:
cmake/platforms/Android.cmake
include/lldb/Core/RegularExpression.h
include/lldb/Host/Config.h
include/lldb/Host/Editline.h
include/lldb/Host/Host.h
include
labath updated this revision to Diff 80046.
labath added a comment.
Remove ifdef in driver.cpp -- it is completely unnecessary
https://reviews.llvm.org/D27305
Files:
cmake/platforms/Android.cmake
include/lldb/Core/RegularExpression.h
include/lldb/Host/Config.h
include/lldb/Host/Editline
labath added a comment.
I've tried to unify this slightly, but sometimes further unification would make
things inconsistent with surrounding preprocessor directives.
I was suprised by the presence of some of these ifdefs as well -- some of them
seem completely unnecessary. I think that at some
labath updated this revision to Diff 80043.
labath added a comment.
Update to use __ANDROID__
https://reviews.llvm.org/D27305
Files:
cmake/platforms/Android.cmake
include/lldb/Core/RegularExpression.h
include/lldb/Host/Config.h
include/lldb/Host/Editline.h
include/lldb/Host/Host.h
i
tberghammer added inline comments.
Comment at: include/lldb/Core/RegularExpression.h:34
#else
-#if __ANDROID_NDK__
+#if ANDROID
#include
In most case you use "#ifdef". It would be nice to uniformalize
Comment at: source/Plugins/Language/CPlu
labath planned changes to this revision.
labath added a comment.
Thanks for the suggestion. I'll try using `__ANDROID__` instead.
Comment at: cmake/platforms/Android.cmake:36
# flags and definitions
remove_definitions( -DANDROID -D__ANDROID__ )
+add_definitions( -DANDROID -DL
danalbert added inline comments.
Comment at: cmake/platforms/Android.cmake:36
# flags and definitions
remove_definitions( -DANDROID -D__ANDROID__ )
+add_definitions( -DANDROID -DLLDB_DISABLE_LIBEDIT )
You're removing it a line before just to add it back?
`__AN
labath created this revision.
labath added reviewers: tberghammer, zturner.
labath added a subscriber: lldb-commits.
Herald added subscribers: mgorny, srhines, danalbert.
This replaces all the uses of the __ANDROID_NDK__ define with ANDROID. This is a
preparatory step to remove our custom android
