[Lldb-commits] [PATCH] D27282: Accommodate line-0 records in a test

2016-11-30 Thread Paul Robinson via Phabricator via lldb-commits
probinson added a comment. Thanks for helping to decipher the test result! Repository: rL LLVM https://reviews.llvm.org/D27282 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D27282: Accommodate line-0 records in a test

2016-11-30 Thread Paul Robinson via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL288282: PR31214: Make a test tolerate "line 0" when stepping by instruction. (authored by probinson). Changed prior to commit: https://reviews.llvm.org/D27282?vs=79813&id=79824#toc Repository: rL LLV

[Lldb-commits] [PATCH] D27282: Accommodate line-0 records in a test

2016-11-30 Thread Jim Ingham via Phabricator via lldb-commits
jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. And remember to check the accept revision... https://reviews.llvm.org/D27282 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://l

[Lldb-commits] [PATCH] D27282: Accommodate line-0 records in a test

2016-11-30 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. That's great. The source stepping should never have to do this by hand, so special casing the instruction stepping was perfect. https://reviews.llvm.org/D27282 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [PATCH] D27282: Accommodate line-0 records in a test

2016-11-30 Thread Paul Robinson via Phabricator via lldb-commits
probinson added a comment. Forgot to mention this is for PR31214. https://reviews.llvm.org/D27282 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D27282: Accommodate line-0 records in a test

2016-11-30 Thread Paul Robinson via Phabricator via lldb-commits
probinson created this revision. probinson added a reviewer: jingham. probinson added a subscriber: LLDB. LLVM is about to start emitting "line 0" records more often in the DWARF line table. One test tripped over this; made the test accommodate the new records. https://reviews.llvm.org/D27282