This revision was automatically updated to reflect the committed changes.
Closed by commit rL285593: Improve ".." handling in FileSpec normalization
(authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D26081?vs=76428&id=76432#toc
Repository:
rL LLVM
https://reviews.llvm.
labath updated this revision to Diff 76428.
labath added a comment.
Fix typo in the test
https://reviews.llvm.org/D26081
Files:
include/lldb/Host/FileSpec.h
source/Host/common/FileSpec.cpp
source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
unittests/Host/FileSpecTest.cpp
Index: unitt
labath added inline comments.
Comment at: source/Host/common/FileSpec.cpp:550
+ (m_filename.GetStringRef() != ".." && m_filename.GetStringRef() != "."))
+return *this;
amccarth wrote:
> Do we have to worry about an unnecessary single dot in the directo
labath updated this revision to Diff 76426.
labath added a comment.
Fix handling of single dots and add tests for that.
https://reviews.llvm.org/D26081
Files:
include/lldb/Host/FileSpec.h
source/Host/common/FileSpec.cpp
source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
unittests/Host
labath added a comment.
Good point about the single dots. I'll add the tests and make sure they work
properly.
https://reviews.llvm.org/D26081
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
amccarth added inline comments.
Comment at: source/Host/common/FileSpec.cpp:550
+ (m_filename.GetStringRef() != ".." && m_filename.GetStringRef() != "."))
+return *this;
Do we have to worry about an unnecessary single dot in the directory, like
`/foo/
labath created this revision.
labath added reviewers: clayborg, zturner.
labath added a subscriber: lldb-commits.
.. handling for windows path was completely broken because the function was
expecting \ as path separators, but we were passing it normalized file paths,
where these have been replaced
