tberghammer added a comment.
Sorry, I missed that part. I just submitted r284831 what should fix the header
order for both case.
Repository:
rL LLVM
https://reviews.llvm.org/D25733
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http:/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284829: Add data formatter for libstdc++ tuple (authored by
tberghammer).
Changed prior to commit:
https://reviews.llvm.org/D25733?vs=75417&id=75433#toc
Repository:
rL LLVM
https://reviews.llvm.org/
Eugene.Zelenko added a comment.
Headers orders is still not correct.
Repository:
rL LLVM
https://reviews.llvm.org/D25733
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tberghammer updated this revision to Diff 75417.
tberghammer marked 4 inline comments as done.
https://reviews.llvm.org/D25733
Files:
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/tuple/Makefile
packages/Python/lldbsuite/test/functionalities/data
labath added a comment.
Just minor nits from my side.
Comment at:
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/tuple/Makefile:5
+
+CXXFLAGS := -O0
+USE_LIBSTDCPP := 1
I don't think this is necessary.
Eugene.Zelenko added a comment.
There are same problems with formatting as in https://reviews.llvm.org/D25726.
Also test case main() has wrong indentation.
https://reviews.llvm.org/D25733
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
tberghammer created this revision.
tberghammer added reviewers: labath, granata.enrico.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: mgorny, beanz.
Add data formatter for libstdc++ tuple
https://reviews.llvm.org/D25733
Files:
packages/Python/lldbsuite/test/function
