[Lldb-commits] [PATCH] D25490: [CMake] Cleanup check-lldb targets

2016-10-13 Thread Todd Fiala via lldb-commits
tfiala added a comment. (Retro) Ah nice, I like the generator expression you put in there. Repository: rL LLVM https://reviews.llvm.org/D25490 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[Lldb-commits] [PATCH] D25490: [CMake] Cleanup check-lldb targets

2016-10-12 Thread Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL284046: [CMake] Cleanup check-lldb targets (authored by cbieneman). Changed prior to commit: https://reviews.llvm.org/D25490?vs=74296&id=74434#toc Repository: rL LLVM https://reviews.llvm.org/D25490

[Lldb-commits] [PATCH] D25490: [CMake] Cleanup check-lldb targets

2016-10-11 Thread Zachary Turner via lldb-commits
zturner accepted this revision. zturner added inline comments. This revision is now accepted and ready to land. Comment at: test/CMakeLists.txt:12 +DEPENDS ${LLDB_TEST_DEPS} +USES_TERMINAL ) OMG. I've been looking for this magic for forever. Praise

[Lldb-commits] [PATCH] D25490: [CMake] Cleanup check-lldb targets

2016-10-11 Thread Chris Bieneman via lldb-commits
beanz created this revision. beanz added reviewers: tfiala, zturner. beanz added a subscriber: lldb-commits. Herald added a subscriber: mgorny. This patch adds the following fixes to the check-lldb targets: - Adds missing dependencies on lldb tools so they get built before tests execute - Adds Ni