This revision was automatically updated to reflect the committed changes.
Closed by commit rL285702: Remove TimeValue usage from FileSpec.h (authored by
labath).
Changed prior to commit:
https://reviews.llvm.org/D25392?vs=76573&id=76576#toc
Repository:
rL LLVM
https://reviews.llvm.org/D2539
labath updated this revision to Diff 76573.
labath marked 2 inline comments as done.
labath added a comment.
- cleanup constructors
- use llvm's stat() implementation
https://reviews.llvm.org/D25392
Files:
include/lldb/Core/Module.h
include/lldb/Core/ModuleSpec.h
include/lldb/Core/SourceM
labath added inline comments.
Comment at: include/lldb/Host/FileSystem.h:69-71
+ static std::chrono::time_point
+ GetModificationTime(const FileSpec &file_spec);
labath wrote:
> zturner wrote:
> > I wonder if it would be worth defining some typedefs in LLVM's `
Yea let's just duration_cast before calling to_time_t
On Sat, Oct 8, 2016 at 4:23 PM Pavel Labath wrote:
> labath added inline comments.
>
>
>
> Comment at: include/lldb/Host/TimeValue.h:37-38
>explicit TimeValue(uint32_t seconds, uint64_t nanos = 0);
> + TimeValue(std::chro
labath added inline comments.
Comment at: include/lldb/Host/TimeValue.h:37-38
explicit TimeValue(uint32_t seconds, uint64_t nanos = 0);
+ TimeValue(std::chrono::time_point
+point)
labath wrote:
> zturner wrote:
> > Is there any reason to expli
labath added inline comments.
Comment at: include/lldb/Host/FileSystem.h:69-71
+ static std::chrono::time_point
+ GetModificationTime(const FileSpec &file_spec);
zturner wrote:
> I wonder if it would be worth defining some typedefs in LLVM's `Chrono.h`
> that
zturner added inline comments.
Comment at: include/lldb/Host/FileSystem.h:69-71
+ static std::chrono::time_point
+ GetModificationTime(const FileSpec &file_spec);
I wonder if it would be worth defining some typedefs in LLVM's `Chrono.h` that
Mehdi is adding to
labath added a subscriber: mehdi_amini.
labath added inline comments.
Comment at: source/Host/common/FileSystem.cpp:103
+
+ return system_clock::from_time_t(file_stats.st_mtimespec.tv_sec) +
+ nanoseconds(file_stats.st_mtimespec.tv_nsec);
The conversion
labath created this revision.
labath added reviewers: clayborg, zturner.
labath added a subscriber: lldb-commits.
Herald added subscribers: mgorny, beanz, danalbert, tberghammer.
The only usage there was in GetModificationTime(). I also took the opportunity
to move this function from FileSpec to t
