It looks like there was a problem with this after all. Are your OSX
buildbots failing? I only got notification from Linux buildbots. I'm
pretty sure everything passes, but I'm going to test again real quick to
confirm.
On Wed, Oct 5, 2016 at 10:17 AM Zachary Turner wrote:
> This revision was
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283345: Convert some breakpoint code to use StringRef.
(authored by zturner).
Changed prior to commit:
https://reviews.llvm.org/D25158?vs=73554&id=73667#toc
Repository:
rL LLVM
https://reviews.llvm.
Ah, missed it there. No it is fine to put it in the header.
Jim
> On Oct 4, 2016, at 2:37 PM, Zachary Turner wrote:
>
> zturner added inline comments.
>
>
>> jingham wrote in BreakpointIDList.cpp:329-330
>> Did you upload the latest version of your patch, I don't see a comment
>> here...
>
zturner added inline comments.
> jingham wrote in BreakpointIDList.cpp:329-330
> Did you upload the latest version of your patch, I don't see a comment here...
I put the comment in the header. I can put it here if you prefer. Putting it
on both places seems unnecessary though. LMK which you
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
No good deed goes unpunished... You made ParseCanonicalReference more
beautiful but forgot to update the header doc.
Also I didn't see the comment for SplitIDRangeExpression.
>
zturner updated this revision to Diff 73554.
zturner added a comment.
Fixed up `ParseCanonicalReference` and `SplitIDRangeExpression` as suggested.
I could have probably returned an `Optional>`
but it seemed like overkill. An empty pair seems sufficient for conveying
failure.
https://review
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
This looks correct to me. I had a couple of trivial inline comments, but this
looks fine.
> BreakpointID.cpp:80-81
>
> -bool BreakpointID::ParseCanonicalReference(const char *input,
> +
zturner created this revision.
zturner added a reviewer: jingham.
zturner added a subscriber: lldb-commits.
This is an incremental step towards getting some other code converted. In any
case, I believe this makes the breakpoint code significantly easier to
understand and also removes many strin
