This revision was automatically updated to reflect the committed changes.
Closed by commit rL282537: Update FileSpec's interface to use StringRefs.
(authored by zturner).
Changed prior to commit:
https://reviews.llvm.org/D24936?vs=72555&id=72705#toc
Repository:
rL LLVM
https://reviews.llvm.
amccarth added a subscriber: amccarth.
Comment at: source/Host/common/FileSpec.cpp:1317
@@ +1316,3 @@
+
+ char sep = GetPrefferedPathSeparator(m_syntax);
+ std::string result;
Function is misspelled. Should be `GetPreferredPathSeparator` (1 'f', 2 'r's),
throu
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Watch the buildbots for failures, but this looks fine. We aren't changing how
the strings for filename and directory are stored, just using StringRef to
deliver the arguments.
https://re
zturner created this revision.
zturner added a reviewer: clayborg.
zturner added a subscriber: lldb-commits.
zturner added a dependency: D24880: Add StringExtras join_items function.
This patch depends on D24880 going in for the `join_items` function, but at
least you can comment on it now.
ht
