This revision was automatically updated to reflect the committed changes.
Closed by commit rL282314: [CMake] Generate LLDB_REVISION at build time
(authored by cbieneman).
Changed prior to commit:
https://reviews.llvm.org/D24846?vs=72215&id=72381#toc
Repository:
rL LLVM
https://reviews.llvm.
zturner accepted this revision.
zturner added a comment.
lgtm, everything works.
https://reviews.llvm.org/D24846
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
Looks good.
I think it's fine landing here for now based on your earlier comments about the
refactoring effort to get it into LLVM/clang. I do think it's worth trying to
sink it lower when t
If it's non trivial then then can go in first, that's fine. I'm ooo for the
rest of the day, so let me test it out on Windows first
On Thu, Sep 22, 2016 at 4:36 PM Chris Bieneman wrote:
> beanz added a comment.
>
> Putting this in LLVM would be ideal, but I think doing that requires a
> larger re
beanz added a comment.
Putting this in LLVM would be ideal, but I think doing that requires a larger
refactoring of how LLVM and Clang handle SCM versions. I was kinda hoping to
land this and fix the lldb support, but if you'd prefer I can shelve this until
after fixing LLVM & Clang.
https://
zturner added a comment.
Should this be sunk into a common llvm function instead of copying from clang?
I don't have a strong opinion, but are you one of the main CMake maintainers in
LLVM, so whatever you think is best.
https://reviews.llvm.org/D24846
_
beanz created this revision.
beanz added reviewers: tfiala, zturner.
beanz added a subscriber: lldb-commits.
Herald added subscribers: mgorny, beanz.
This alters the generation of LLDB_REVISION to be heavily based on how clang
generates its version header. There are two benefits of this aproach.
