This revision was automatically updated to reflect the committed changes.
Closed by commit rL280476: Make Scalar::GetValue more consistent (authored by
labath).
Changed prior to commit:
https://reviews.llvm.org/D24126?vs=69979&id=70140#toc
Repository:
rL LLVM
https://reviews.llvm.org/D24126
Actually you're right, i read the test backwards and thought the string was
the argument. I shouldn't do this 30 seconds after waking up :)
On Thu, Sep 1, 2016 at 7:26 AM Pavel Labath wrote:
> I don't think that even makes sense. :)
>
> Scalar class has constructors overrides for each of the prim
I don't think that even makes sense. :)
Scalar class has constructors overrides for each of the primitive
types. I cannot construct it with a value which is larger than it will
fit in the primitive type. I suppose I could try the boundary
conditions like UINT32_MAX, but that's about it.
Or I am m
What about a case in the unit test where the value overflows the type?
Would that be useful?
On Thu, Sep 1, 2016 at 3:50 AM Pavel Labath via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> labath created this revision.
> labath added reviewers: clayborg, granata.enrico.
> labath added a subsc
labath created this revision.
labath added reviewers: clayborg, granata.enrico.
labath added a subscriber: lldb-commits.
It seems the original intention of the function was printing signed values in
decimal format, and
unsigned values in hex (without the leading "0x"). However, signed and unsigne
