This revision was automatically updated to reflect the committed changes.
Closed by commit rL290044: Support of lldb on Kfreebsd (authored by sylvestre).
Changed prior to commit:
https://reviews.llvm.org/D23977?vs=77714&id=81842#toc
Repository:
rL LLVM
https://reviews.llvm.org/D23977
Files
beanz added a comment.
Looks fine to me.
https://reviews.llvm.org/D23977
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
Looks reasonable to me.
@beanz, any comments on this?
https://reviews.llvm.org/D23977
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
sylvestre.ledru updated this revision to Diff 77714.
https://reviews.llvm.org/D23977
Files:
cmake/LLDBDependencies.cmake
cmake/modules/LLDBConfig.cmake
scripts/Python/modules/CMakeLists.txt
scripts/utilsOsType.py
Index: scripts/utilsOsType.py
tfiala requested changes to this revision.
tfiala added a comment.
This revision now requires changes to proceed.
Okay. I think we need a minor tweak, to drop the REQUIRED on the Backtrace
usage.
https://reviews.llvm.org/D23977
___
lldb-commits ma
krytarowski added inline comments.
Comment at: cmake/modules/LLDBConfig.cmake:414
+
+find_package(Backtrace REQUIRED)
tfiala wrote:
> Hi Sylvestre!
>
> It's hard to tell without more context, but it looks like this location has
> most/all configurations going t
tfiala added inline comments.
Comment at: cmake/modules/LLDBConfig.cmake:414
+
+find_package(Backtrace REQUIRED)
Hi Sylvestre!
It's hard to tell without more context, but it looks like this location has
most/all configurations going through it. For OSes that d
sylvestre.ledru updated this revision to Diff 72758.
sylvestre.ledru added a comment.
Herald added subscribers: mgorny, beanz.
Updated by Pino!
https://reviews.llvm.org/D23977
Files:
cmake/LLDBDependencies.cmake
cmake/modules/LLDBConfig.cmake
scripts/Python/modules/CMakeLists.txt
script
emaste requested changes to this revision.
emaste added a reviewer: emaste.
emaste added a comment.
This revision now requires changes to proceed.
Two requested changes called out in comments above
https://reviews.llvm.org/D23977
___
lldb-commits ma
tfiala added a comment.
@sylvestre.ledru, I think this will be ready to go if you can convert that
check to a CMake built-in check. Maybe you can pass that along to Pino Toscano?
https://reviews.llvm.org/D23977
___
lldb-commits mailing list
lldb-c
tfiala added inline comments.
Comment at: cmake/LLDBDependencies.cmake:168
@@ -167,3 +167,3 @@
# On FreeBSD/NetBSD backtrace() is provided by libexecinfo, not libc.
-if (CMAKE_SYSTEM_NAME MATCHES "FreeBSD" OR CMAKE_SYSTEM_NAME MATCHES "NetBSD")
+if ((CMAKE_SYSTEM_NAME MATCHES "Fr
emaste added a subscriber: emaste.
emaste added a comment.
- in the future can you please upload with context (e.g. git diff -U)
- I think the OS names in utilsOsType.py are kept sorted and the actual enum
values are not part of an ABI
https://reviews.llvm.org/D23977
krytarowski added a subscriber: krytarowski.
Comment at: cmake/LLDBDependencies.cmake:168
@@ -167,3 +167,3 @@
# On FreeBSD/NetBSD backtrace() is provided by libexecinfo, not libc.
-if (CMAKE_SYSTEM_NAME MATCHES "FreeBSD" OR CMAKE_SYSTEM_NAME MATCHES "NetBSD")
+if ((CMAKE_SYSTEM_N
brucem added a subscriber: brucem.
Comment at: cmake/LLDBDependencies.cmake:168
@@ -167,3 +167,3 @@
# On FreeBSD/NetBSD backtrace() is provided by libexecinfo, not libc.
-if (CMAKE_SYSTEM_NAME MATCHES "FreeBSD" OR CMAKE_SYSTEM_NAME MATCHES "NetBSD")
+if ((CMAKE_SYSTEM_NAME MATCHE
sylvestre.ledru created this revision.
sylvestre.ledru added a reviewer: tfiala.
sylvestre.ledru added a subscriber: LLDB.
sylvestre.ledru added a project: LLDB.
Herald added subscribers: srhines, danalbert, tberghammer.
Patch by Pino Toscano. Reported in http://bugs.debian.org/835665
https://rev
15 matches
Mail list logo
