mgorny added a comment.
Yes, thanks a lot.
https://reviews.llvm.org/D23883
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath closed this revision.
labath added a comment.
I am going to assume you still want me to submit this. r281317.
https://reviews.llvm.org/D23883
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
ki.stfu accepted this revision.
ki.stfu added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D23883
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/l
> On Sep 10, 2016, at 11:26 PM, Zachary Turner via lldb-commits
> wrote:
>
> I don't think requiring user install of six would work, lldb should just work
> out of the box. Renaming it to lldb_six might work.
>
> Also yes using llvm regex everywhere would be wonderful, I honestly have no
>
mgorny added a comment.
In https://reviews.llvm.org/D23883#539611, @ki.stfu wrote:
> You forgot to remove its header file
Thanks for noticing. Fixed now.
https://reviews.llvm.org/D23883
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
labath added a comment.
@mgorny: The change should be reviewed by an lldb-mi maintainer (i.e.,
@ki.stfu). It helps is you explicitly specify the reviewer, as otherwise the
person may not notice the patch.
In https://reviews.llvm.org/D23883#539471, @mgorny wrote:
> In https://reviews.llvm.org/D
mgorny updated this revision to Diff 70997.
Herald added subscribers: mgorny, beanz.
https://reviews.llvm.org/D23883
Files:
tools/lldb-mi/CMakeLists.txt
tools/lldb-mi/MIUtilParse.cpp
tools/lldb-mi/MIUtilParse.h
Index: tools/lldb-mi/MIUtilParse.h
ki.stfu requested changes to this revision.
ki.stfu added a reviewer: ki.stfu.
ki.stfu added a comment.
This revision now requires changes to proceed.
You forgot to remove its header file
https://reviews.llvm.org/D23883
___
lldb-commits mailing list
krytarowski added a comment.
In https://reviews.llvm.org/D23883#539471, @mgorny wrote:
> In https://reviews.llvm.org/D23883#539442, @krytarowski wrote:
>
> > It looks good. Remaining TODO for standalone builds:
> >
> > - sanitize six.py usage (it's installed into system-wide directory, where
> >
I don't think requiring user install of six would work, lldb should just
work out of the box. Renaming it to lldb_six might work.
Also yes using llvm regex everywhere would be wonderful, I honestly have no
idea why mi was developed the way it was with an aversion to using llvm
classes
On Sat, Sep
mgorny added a comment.
In https://reviews.llvm.org/D23883#539442, @krytarowski wrote:
> It looks good. Remaining TODO for standalone builds:
>
> - sanitize six.py usage (it's installed into system-wide directory, where
> standard py-six lands)
How would you prefer handling it? Can we just kil
krytarowski added a comment.
It looks good. Remaining TODO for standalone builds:
- sanitize six.py usage (it's installed into system-wide directory, where
standard py-six lands)
- bump cmake_minimum_required(VERSION 2.8.12.2) to 3.4.3 in
cmake/modules/LLDBStandalone.cmake
Final bits for Windo
mgorny added a reviewer: labath.
mgorny added a subscriber: labath.
mgorny added a comment.
@labath, since you committed https://reviews.llvm.org/D23882, could you,
please, take a look at this one as well? It's immediately following that, and
should fix the build issue resulting from use of priv
mgorny created this revision.
mgorny added a reviewer: dawn.
mgorny added a subscriber: lldb-commits.
Herald added a subscriber: ki.stfu.
Remove MIUtilParse once https://reviews.llvm.org/D23882 is accepted.
https://reviews.llvm.org/D23883
Files:
tools/lldb-mi/CMakeLists.txt
tools/lldb-mi/MIU
14 matches
Mail list logo
