clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good!
Comment at: source/API/SBCommandInterpreter.cpp:156
@@ -155,3 +155,3 @@
}
-lldb::SBCommandPluginInterface* m_backend;
+std::shared_ptr m_backend;
abhishek.aggarwal updated this revision to Diff 65903.
abhishek.aggarwal added a comment.
New patch according to review feedback
- Added another variant of AddCommand API with syntax as an additional argument
https://reviews.llvm.org/D22863
Files:
include/lldb/API/SBCommandInterpreter.h
so
labath added inline comments.
Comment at: source/API/SBCommandInterpreter.cpp:156
@@ -155,3 +155,3 @@
}
-lldb::SBCommandPluginInterface* m_backend;
+std::shared_ptr m_backend;
};
abhishek.aggarwal wrote:
> clayborg wrote:
> > Can't change public API,
abhishek.aggarwal added inline comments.
Comment at: include/lldb/API/SBCommandInterpreter.h:141-142
@@ -140,4 +140,4 @@
lldb::SBCommand
-AddCommand (const char* name, lldb::SBCommandPluginInterface *impl, const
char* help);
+AddCommand (const char* name, lldb:
labath added a subscriber: labath.
Comment at: include/lldb/API/SBCommandInterpreter.h:141-142
@@ -140,4 +140,4 @@
lldb::SBCommand
-AddCommand (const char* name, lldb::SBCommandPluginInterface *impl, const
char* help);
+AddCommand (const char* name, lldb::SBCom
abhishek.aggarwal added a comment.
Hi Greg
Please find my comments inlined. Let me know if I am missing something here.
Comment at: include/lldb/API/SBCommandInterpreter.h:141-142
@@ -140,4 +140,4 @@
lldb::SBCommand
-AddCommand (const char* name, lldb::SBCommandP
granata.enrico added a comment.
Everything Greg said makes total sense
In general dynamically loadable C++ plugins as a feature is a little rough
around the edges. I am glad to see interest in improving it!
https://reviews.llvm.org/D22863
___
lldb
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
You can't change the exiting public API (anything in include/lldb/API/*). If
you want to a add a new function, you must add a new version with the new
argument, but leave the old
