jafl updated this revision to Diff 94112.
jafl added a comment.
Merged from master and ran clang-format
Repository:
rL LLVM
https://reviews.llvm.org/D22831
Files:
include/lldb/API/SBAddress.h
Index: include/lldb/API/SBAddress.h
=
Sorry for missing this! What options should I use when running it?
On Mon, Sep 19, 2016 at 2:31 PM, Eugene Zelenko
wrote:
> Eugene.Zelenko added a subscriber: Eugene.Zelenko.
> Eugene.Zelenko added a comment.
>
> Please rebase from trunk and run Clang-format.
>
>
> Repository:
> rL LLVM
>
> h
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Please rebase from trunk and run Clang-format.
Repository:
rL LLVM
https://reviews.llvm.org/D22831
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http:/
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good, thanks for the changes and the documentation.
Repository:
rL LLVM
https://reviews.llvm.org/D22831
___
lldb-commits mailing lis
jafl updated this revision to Diff 67405.
jafl added a comment.
Incorporate additional feedback from Greg Clayton.
Repository:
rL LLVM
https://reviews.llvm.org/D22831
Files:
include/lldb/API/SBAddress.h
Index: include/lldb/API/SBAddress.h
==
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Just a quick clarifications on file and load addresses to make things a bit
clearer.
Comment at: include/lldb/API/SBAddress.h:25-26
@@ +24,4 @@
+///
+/// SBAddr
jafl updated this revision to Diff 66678.
jafl added a comment.
Incorporated feedback
Repository:
rL LLVM
https://reviews.llvm.org/D22831
Files:
include/lldb/API/SBAddress.h
Index: include/lldb/API/SBAddress.h
===
--- include
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
A few modifications to the SBAddress info
Comment at: include/lldb/API/SBAddress.h:32
@@ +31,3 @@
+/// target.
+///
+/// The individual Get*() functions grab ind
