Re: [Lldb-commits] [PATCH] D22756: Fix incorrect form test in SymbolFileDWARF

2016-07-26 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL276735: Fix incorrect form test in SymbolFileDWARF (authored by labath). Changed prior to commit: https://reviews.llvm.org/D22756?vs=65340&id=65479#toc Repository: rL LLVM https://reviews.llvm.org/D

Re: [Lldb-commits] [PATCH] D22756: Fix incorrect form test in SymbolFileDWARF

2016-07-25 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. https://reviews.llvm.org/D22756 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

[Lldb-commits] [PATCH] D22756: Fix incorrect form test in SymbolFileDWARF

2016-07-25 Thread Pavel Labath via lldb-commits
labath created this revision. labath added a reviewer: clayborg. labath added a subscriber: lldb-commits. We were checking whether an attribute is in block form by getting the block data pointer, which was not correct as the pointer be null even if the attribute is in block form. Other places in