Re: [Lldb-commits] [PATCH] D22230: Make ThreadPlanStepInstruction's constructor public.

2016-07-11 Thread Stephane Sezer via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL275139: Make ThreadPlanStepInstruction's constructor public. (authored by sas). Changed prior to commit: http://reviews.llvm.org/D22230?vs=63625&id=63627#toc Repository: rL LLVM http://reviews.llvm.

Re: [Lldb-commits] [PATCH] D22230: Make ThreadPlanStepInstruction's constructor public.

2016-07-11 Thread Stephane Sezer via lldb-commits
sas updated this revision to Diff 63625. sas added a comment. Rebase. http://reviews.llvm.org/D22230 Files: include/lldb/Target/ThreadPlanStepInstruction.h Index: include/lldb/Target/ThreadPlanStepInstruction.h === --- include/l

Re: [Lldb-commits] [PATCH] D22230: Make ThreadPlanStepInstruction's constructor public.

2016-07-11 Thread Jim Ingham via lldb-commits
jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Sure, yes. http://reviews.llvm.org/D22230 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

Re: [Lldb-commits] [PATCH] D22230: Make ThreadPlanStepInstruction's constructor public.

2016-07-11 Thread Greg Clayton via lldb-commits
clayborg resigned from this revision. clayborg edited reviewers, added: jingham; removed: clayborg. clayborg added a comment. Looks good to me, but for any thread plan stuff, I will defer to Jim Ingham. http://reviews.llvm.org/D22230 ___ lldb-commit

[Lldb-commits] [PATCH] D22230: Make ThreadPlanStepInstruction's constructor public.

2016-07-11 Thread Stephane Sezer via lldb-commits
sas created this revision. sas added reviewers: clayborg, zturner. sas added a subscriber: lldb-commits. Some thread plans have public contructors, some others have protected constructors with friend classes. Not sure how these were determined, but this thread plan is going to be required to imple