Re: [Lldb-commits] [PATCH] D22213: [test] Fix category-based skipping

2016-07-18 Thread Todd Fiala via lldb-commits
tfiala added a comment. > ! In https://reviews.llvm.org/D22213#481728, @labath wrote: > I don't remember seeing any changes here so it's quite possible it never > worked in the first place, but I have no idea what could be different about > my setup. I'll have to have a look at it. Thanks f

Re: [Lldb-commits] [PATCH] D22213: [test] Fix category-based skipping

2016-07-12 Thread Pavel Labath via lldb-commits
labath added a comment. I used the command you mentioned in the original patch: $ python -m unittest discover -s test/src -p 'Test*.py' FF == FAIL: test_with_function_filter (TestCatchInvalidDecorator.TestCatchInvalidDec

Re: [Lldb-commits] [PATCH] D22213: [test] Fix category-based skipping

2016-07-12 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL275173: [test] Fix category-based skipping (authored by labath). Changed prior to commit: http://reviews.llvm.org/D22213?vs=63487&id=63679#toc Repository: rL LLVM http://reviews.llvm.org/D22213 Fil

Re: [Lldb-commits] [PATCH] D22213: [test] Fix category-based skipping

2016-07-12 Thread Todd Fiala via lldb-commits
tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. In http://reviews.llvm.org/D22213#480052, @labath wrote: > Btw, I tried to make a unit test for this, but I could not get your meta test > runner to work -- the existing test was failing for m

Re: [Lldb-commits] [PATCH] D22213: [test] Fix category-based skipping

2016-07-11 Thread Pavel Labath via lldb-commits
labath added a comment. Btw, I tried to make a unit test for this, but I could not get your meta test runner to work -- the existing test was failing for me (it was not getting any events apart from the global "test run started"/"test run finished" events). Do you have any idea what could be wr

[Lldb-commits] [PATCH] D22213: [test] Fix category-based skipping

2016-07-11 Thread Pavel Labath via lldb-commits
labath created this revision. labath added a reviewer: tfiala. labath added a subscriber: lldb-commits. LLDBTestResult.hardMarkAsSkipped marked the whole class as skipped when the first class in the test failed the category check. This meant that subsequent tests in the same class did not run ev