ovyalov closed this revision.
ovyalov added a comment.
Files:
/lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp
/lldb/trunk/source/Plugins/Platform/Android/AdbClient.h
/lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.cpp
/lldb/trunk/source/Plugins/Platform/Android/Platf
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
ok, sounds good.
http://reviews.llvm.org/D21770
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
ovyalov added a comment.
If you okay with that I'd like to submit this CL as-is and come up with unit
test with a separate change list.
http://reviews.llvm.org/D21770
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/c
ovyalov added a comment.
In http://reviews.llvm.org/D21770#469876, @labath wrote:
> Is AdbClient getting big enough to deserve a couple of unit tests? All it
> would take is to add the ability to specify the address to connect to and
> make a small mock server that listens at that address?
It
labath added a comment.
Is AdbClient getting big enough to deserve a couple of unit tests? All it would
take is to add the ability to specify the address to connect to and make a
small mock server that listens at that address?
http://reviews.llvm.org/D21770
_
ovyalov created this revision.
ovyalov added reviewers: labath, tberghammer.
ovyalov added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
- Extract sync commands like push/pull file and stat into SyncService so ADB
connection that's switched in sync mode can be reu
