ted added a subscriber: ted.
ted added a comment.
The Hexagon platform (currently in-house only) acts like the ios simulator
platform, in that it doesn't connect - it fixes up the command line, then
launches the Hexagon simulator (based on the debugserver launch code in the
gdb-remote process p
clayborg added a comment.
Platforms are funny because the "ios-simulator" platform doesn't need to be
connected for anything since it exists and runs things locally. The platform is
there to help us launch our processes so they run as simulator binaries, and
also to help locate files and other
fjricci abandoned this revision.
fjricci added a comment.
I don't think that we can assume that the user always wants to re-use an
existing platform, even of the same type. Probably the only way to resolve the
problem this tries to fix would be to add a command to display all connected
platform
fjricci added a comment.
Although, given your comments about the ios platforms, IsConnected() doesn't
seem like the right API to use anyway...
http://reviews.llvm.org/D21649
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llv
fjricci added a comment.
As I'm poking through the APIs, I found that platform_sp->IsConnected() will
return true even if the remote server has been killed since connecting (at
least on remote-linux with lldb-server in platform mode). Is this the expected
behavior of that set of functions?
ht
clayborg requested changes to this revision.
clayborg added a comment.
Sorry missed your comments about when a platform dies. Also be sure to know
that you might not have to connect to a platform for it to be useful. We have
ios-simulator platforms that don't require connecting.
http://reviews
clayborg accepted this revision.
clayborg added a comment.
Make sure you keep a very close eye on all the buildbots with this one. I agree
this change is good, but I seem to remember there were problems when this was
done.
http://reviews.llvm.org/D21649
_
fjricci planned changes to this revision.
fjricci added a comment.
This will fail in the case where the remote-platform server dies, as lldb will
not cleanup its data structures. I'll investigate how to make sure the platform
is alive before connecting to it.
http://reviews.llvm.org/D21649
fjricci created this revision.
fjricci added reviewers: clayborg, jingham, vharron.
fjricci added subscribers: sas, lldb-commits.
When using 'platform select', re-use an existing platform
which matches the remote platform specs, rather than creating a new one.
Without this patch, repeating the fo
