Thanks Hans.
-Original Message-
From: hwennb...@google.com [mailto:hwennb...@google.com] On Behalf Of Hans
Wennborg
Sent: 09 August 2016 01:58
To: Greg Clayton
Cc: Nitesh Jain; Jaydeep Patil; Bhushan Attarde; lldb-commits@lists.llvm.org
Subject: Re: [PATCH] D20357: [LLDB][MIPS] Fix FPU Si
Thanks! Merged in r278046.
On Mon, Aug 8, 2016 at 10:25 AM, Greg Clayton wrote:
> I am fine with this going in, but this fix is for MIPS only.
>
>
>> On Aug 2, 2016, at 8:47 AM, Hans Wennborg wrote:
>>
>> Looks like a pretty big change to merge at this stage.
>>
>> I'll let Clayton decide.
>>
>>
I am fine with this going in, but this fix is for MIPS only.
> On Aug 2, 2016, at 8:47 AM, Hans Wennborg wrote:
>
> Looks like a pretty big change to merge at this stage.
>
> I'll let Clayton decide.
>
> Thanks,
> Hans
>
> On Mon, Aug 1, 2016 at 11:25 PM, Nitesh Jain wrote:
>> Hi Hans,
>>
Looks like a pretty big change to merge at this stage.
I'll let Clayton decide.
Thanks,
Hans
On Mon, Aug 1, 2016 at 11:25 PM, Nitesh Jain wrote:
> Hi Hans,
>
> Could you please add this to the LLDB 3.9 release branch ?
>
> Thanks & regards,
> Nitesh Jain
>
>
> -Original Message-
> From:
nitesh.jain added a comment.
Thanks Greg for all your help.
Repository:
rL LLVM
https://reviews.llvm.org/D20357
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good, thanks for all of the updates.
https://reviews.llvm.org/D20357
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://l
nitesh.jain marked 9 inline comments as done.
nitesh.jain added a comment.
https://reviews.llvm.org/D20357
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
A few comments:
- we need the DWARF opcode length in RegisterInfo, but not in the structured
data (XML or JSON)
- all macros that initialize RegisterInfo structs must be expended
nitesh.jain marked 8 inline comments as done.
nitesh.jain added a comment.
https://reviews.llvm.org/D20357
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
nitesh.jain updated this revision to Diff 64693.
nitesh.jain added a comment.
Removed dynamic_size_dwarf_len field from RegisterInfo struct.
https://reviews.llvm.org/D20357
Files:
include/lldb/Host/common/NativeRegisterContext.h
include/lldb/Host/common/NativeRegisterContextRegisterInfo.h
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Many issues. See inlined comments.
Comment at: include/lldb/lldb-private-types.h:57-58
@@ -56,1 +56,4 @@
// ax, ah, and al.
+
nitesh.jain added a comment.
Hi Greg,
Please could you find some time to review this ?
Thanks
http://reviews.llvm.org/D20357
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
nitesh.jain marked an inline comment as done.
nitesh.jain added a comment.
http://reviews.llvm.org/D20357
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
nitesh.jain removed rL LLVM as the repository for this revision.
nitesh.jain updated this revision to Diff 63224.
nitesh.jain added a comment.
Added lldb_private::RegisterInfo * DynamicRegisterInfo::GetRegisterInfoAtIndex
(uint32_t i)
http://reviews.llvm.org/D20357
Files:
include/lldb/lldb-
labath added inline comments.
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp:98
@@ +97,3 @@
+const ArchSpec &arch =
m_thread.GetProcess()->GetTarget().GetArchitecture();
+RegisterInfo* reg_info = const_cast(m_reg_info.GetRegisterInfoAtIndex (re
nitesh.jain added inline comments.
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp:98
@@ +97,3 @@
+const ArchSpec &arch =
m_thread.GetProcess()->GetTarget().GetArchitecture();
+RegisterInfo* reg_info = const_cast(m_reg_info.GetRegisterInfoAtInde
labath added inline comments.
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp:98
@@ +97,3 @@
+const ArchSpec &arch =
m_thread.GetProcess()->GetTarget().GetArchitecture();
+RegisterInfo* reg_info = const_cast(m_reg_info.GetRegisterInfoAtIndex (re
nitesh.jain marked an inline comment as done.
nitesh.jain added a comment.
Repository:
rL LLVM
http://reviews.llvm.org/D20357
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
nitesh.jain marked 6 inline comments as done.
nitesh.jain added a comment.
Repository:
rL LLVM
http://reviews.llvm.org/D20357
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
nitesh.jain retitled this revision from "[LLDB][MIPS] Fix FPU Size Based on
Dynamic FR/FRE bit" to "[LLDB][MIPS] Fix FPU Size Based on Dynamic FR".
nitesh.jain updated the summary for this revision.
nitesh.jain updated this revision to Diff 63201.
nitesh.jain added a comment.
Update diff as per s
clayborg added a comment.
There should be no need to add code on the lldb-server side. It would just send
the DWARF expression bytes over when qRegisterInfo or the target xml is sent to
the host. The host would store this expression and run it each time the
register info is asked for for a regi
labath added a subscriber: labath.
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp:497-505
@@ +496,11 @@
+ {
+bool fre;
+bool fr1;
+IsFR1_FRE (fr1, fre);
+
+// fr1 fre fpu_reg_size
+
nitesh.jain added inline comments.
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp:497-505
@@ +496,11 @@
+ {
+bool fre;
+bool fr1;
+IsFR1_FRE (fr1, fre);
+
+// fr1 fre fpu_reg_size
+
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
So this is close. My idea was that the lldb-server would not just set a
key/value pair named "dynamic_size" to "1" in the "qRegisterInfo" or
"$qXfer:features:read:target.xml:0,1f
24 matches
Mail list logo
