This revision was automatically updated to reflect the committed changes.
Closed by commit rL269793: Allow custom formatting of session log file names.
(authored by zturner).
Changed prior to commit:
http://reviews.llvm.org/D20306?vs=57409&id=57502#toc
Repository:
rL LLVM
http://reviews.llv
tfiala accepted this revision.
tfiala added a comment.
(Changing to Accept - although please have a look at the comments from Pavel
and me).
http://reviews.llvm.org/D20306
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
I agree with Todd that we should have a long option for this, as short ones
tend to be cryptic. If we don't anticipate using this often (I don't), we could
even drop the short option altogethe
tfiala added a comment.
Okay I had a look now. Just one comment on the code (inline), just for
consideration. Other than that, LGTM.
Comment at: packages/Python/lldbsuite/test/dotest_args.py:73
@@ -72,2 +72,3 @@
group.add_argument('-s', metavar='name', help='Specify the
tfiala added a comment.
Hi Zachary,
I'll have a look at this first thing in the morning!
-Todd
http://reviews.llvm.org/D20306
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner created this revision.
zturner added reviewers: labath, tfiala.
zturner added a subscriber: lldb-commits.
I'm trying to get the LLDB buildbot to run tests, and currently the issue is
that many tests fail when trying to write the session log file. The build
directory on the buildbot is a
