This revision was automatically updated to reflect the committed changes.
Closed by commit rL267048: Update Go OS Plugin for newer runtimes. (authored by
ribrdb).
Changed prior to commit:
http://reviews.llvm.org/D19273?vs=54427&id=54572#toc
Repository:
rL LLVM
http://reviews.llvm.org/D19273
tberghammer accepted this revision.
tberghammer added a reviewer: tberghammer.
tberghammer added a comment.
A producer string would be excellent but I know it is not easy to add it to all
part of the toolchain. In case of development compilers I would suggest to add
the version number of the nex
ribrdb removed rL LLVM as the repository for this revision.
ribrdb updated this revision to Diff 54427.
http://reviews.llvm.org/D19273
Files:
source/Plugins/OperatingSystem/Go/OperatingSystemGo.cpp
Index: source/Plugins/OperatingSystem/Go/OperatingSystemGo.cpp
=
ribrdb marked an inline comment as done.
ribrdb added a comment.
I'm not sure how else we could identify the runtime version. I'm hoping to
eventually add a producer string that has the version, but this would just be a
git commit for development compilers.
Repository:
rL LLVM
http://review
tberghammer added a subscriber: tberghammer.
tberghammer added a comment.
Is it possible to query the version of the go runtime we are currently
debugging and decide which symbol we look for instead of using this fallback
mechanism? I think it would make the code easier to understand and also ea
labath added a comment.
btw, this does not seem to follow lldb code style (braces on a new line),
please reformat that.
Repository:
rL LLVM
http://reviews.llvm.org/D19273
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llv
labath added a subscriber: labath.
labath accepted this revision.
labath added a reviewer: labath.
This revision is now accepted and ready to land.
Comment at: source/Plugins/OperatingSystem/Go/OperatingSystemGo.cpp:253
@@ +252,3 @@
+ValueObjectSP allgs_sp = FindGlobal(target_
ribrdb created this revision.
ribrdb added a subscriber: lldb-commits.
ribrdb set the repository for this revision to rL LLVM.
Repository:
rL LLVM
http://reviews.llvm.org/D19273
Files:
source/Plugins/OperatingSystem/Go/OperatingSystemGo.cpp
Index: source/Plugins/OperatingSystem/Go/Operating
