Re: [Lldb-commits] [PATCH] D19136: Don't disable stdin and stdout buffering on Windows

2016-04-14 Thread Adrian McCarthy via lldb-commits
amccarth closed this revision. amccarth added a comment. http://reviews.llvm.org/rL266384 http://reviews.llvm.org/D19136 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D19136: Don't disable stdin and stdout buffering on Windows

2016-04-14 Thread Adrian McCarthy via lldb-commits
amccarth added a comment. In http://reviews.llvm.org/D19136#401888, @zturner wrote: > I think you can probably leave buffering turned off for stdout and only do > this change for stdin unless we find some other bug. AFAIK the problem is > confined to stdin. I'd probably leave a comment in `Dr

Re: [Lldb-commits] [PATCH] D19136: Don't disable stdin and stdout buffering on Windows

2016-04-14 Thread Zachary Turner via lldb-commits
zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. I think you can probably leave buffering turned off for stdout and only do this change for stdin unless we find some other bug. AFAIK the problem is confined to stdin. I'd probably leave a

[Lldb-commits] [PATCH] D19136: Don't disable stdin and stdout buffering on Windows

2016-04-14 Thread Adrian McCarthy via lldb-commits
amccarth created this revision. amccarth added a reviewer: zturner. amccarth added a subscriber: lldb-commits. Disabling buffering exposes a bug in the MS VS 2015 CRT implementation of fgets, where you sometimes have to hit Enter twice, depending on if the input had an odd or even number of char