Re: [Lldb-commits] [PATCH] D19082: Store absolute path for lldb executable in dotest.py

2016-04-25 Thread Todd Fiala via lldb-commits
tfiala added a comment. Didn't get to it in time, but yes this looks fine. Repository: rL LLVM http://reviews.llvm.org/D19082 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D19082: Store absolute path for lldb executable in dotest.py

2016-04-25 Thread Francis Ricci via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL267463: Store absolute path for lldb executable in dotest.py (authored by fjricci). Changed prior to commit: http://reviews.llvm.org/D19082?vs=53637&id=54895#toc Repository: rL LLVM http://reviews.l

Re: [Lldb-commits] [PATCH] D19082: Store absolute path for lldb executable in dotest.py

2016-04-14 Thread Pavel Labath via lldb-commits
labath added a subscriber: labath. labath accepted this revision. labath added a reviewer: labath. labath added a comment. This revision is now accepted and ready to land. Not sure what is the difference, but my check-lldb target has already the full path in it. Sounds like a good idea nonetheles

[Lldb-commits] [PATCH] D19082: Store absolute path for lldb executable in dotest.py

2016-04-13 Thread Francis Ricci via lldb-commits
fjricci created this revision. fjricci added reviewers: vharron, zturner, tfiala. fjricci added subscribers: sas, lldb-commits. lldb-server tests are currently being skipped on the check-lldb target. This is because we get the path of lldb-server by modifying the path to the lldb executable. How