This revision was automatically updated to reflect the committed changes.
Closed by commit rL266312: Handle bit fields on big-endian systems correctly
(authored by uweigand).
Changed prior to commit:
http://reviews.llvm.org/D18982?vs=53605&id=53711#toc
Repository:
rL LLVM
http://reviews.llv
uweigand updated this revision to Diff 53605.
uweigand added a comment.
Updated interface documentation in DataExtractor.h.
Added unit test case for the DataExtractor::GetMaxU64Bitfield and
GetMaxS64Bitfield routines.
Retested on System z and Intel.
http://reviews.llvm.org/D18982
Files:
in
labath added a subscriber: labath.
labath added a comment.
It would be worthwhile to add a unit test for the DataExtractor fix (we don't
have many of those, but we're trying to build them up).
http://reviews.llvm.org/D18982
___
lldb-commits mailing
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good as long as all tests still pass on all other systems.
http://reviews.llvm.org/D18982
___
lldb-commits mailing list
lldb-commits@li
uweigand created this revision.
uweigand added reviewers: granata.enrico, clayborg.
uweigand added a subscriber: lldb-commits.
Currently, the DataExtractor::GetMaxU64Bitfield and GetMaxS64Bitfield
routines assume the incoming "bitfield_bit_offset" parameter uses
little-endian bit numbering, i.e. a
