Re: [Lldb-commits] [PATCH] D18978: Support Linux on SystemZ as platform

Pavel Labath wrote on 15.04.2016 11:19:35: > Thanks a lot for cleaning that up. I hope you'll be able to find the > cause of the 32-bit problems quickly. If you need help reproducing the > errors, I can send you some of the detailed logs from our buildbots. I did manage to find the cause of the

Re: [Lldb-commits] [PATCH] D18978: Support Linux on SystemZ as platform

Thanks a lot for cleaning that up. I hope you'll be able to find the cause of the 32-bit problems quickly. If you need help reproducing the errors, I can send you some of the detailed logs from our buildbots. cheers, pl On 14 April 2016 at 22:25, Ulrich Weigand wrote: > Ulrich Weigand/Germany/IB

Re: [Lldb-commits] [PATCH] D18978: Support Linux on SystemZ as platform

Ulrich Weigand/Germany/IBM wrote on 14.04.2016 18:20:20: > So there seem to be at least two different issues, looking at the build bot > logs. After the main SystemZ patch went it, there was just a single > failure, a timeout on the new s390x.core test. I guess we can just disable > that test u

Re: [Lldb-commits] [PATCH] D18978: Support Linux on SystemZ as platform

Pavel Labath wrote on 14.04.2016 17:36:40: > this has broken basically everything on 32-bit targets > >. > Will you be able to track down the problem quickly? I don't expect the > fix to be complicated, but if we ca

Re: [Lldb-commits] [PATCH] D18978: Support Linux on SystemZ as platform

Pavel Labath wrote on 14.04.2016 17:36:40: > this has broken basically everything on 32-bit targets > >. > Will you be able to track down the problem quickly? I don't expect the > fix to be complicated, but if we ca

Re: [Lldb-commits] [PATCH] D18978: Support Linux on SystemZ as platform

labath added a subscriber: labath. labath added a comment. Hi, this has broken basically everything on 32-bit targets http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/13413. Will you be able to track down the problem quickly? I don't expect the fix to be complicated, but if

Re: [Lldb-commits] [PATCH] D18978: Support Linux on SystemZ as platform

Hi, this has broken basically everything on 32-bit targets . Will you be able to track down the problem quickly? I don't expect the fix to be complicated, but if we can't track it down quickly (1-2 hours?) we should sta

Re: [Lldb-commits] [PATCH] D18978: Support Linux on SystemZ as platform

uweigand added a comment. In http://reviews.llvm.org/D18978#400787, @labath wrote: > That's perfect, thanks a lot. :) > > Do you have commit access? If not, let me know when you're ready to start > landing these things... I do have commit access, and have committed the 10 out of 12 patches tha

Re: [Lldb-commits] [PATCH] D18978: Support Linux on SystemZ as platform

labath accepted this revision. labath added a comment. That's perfect, thanks a lot. :) Do you have commit access? If not, let me know when you're ready to start landing these things... http://reviews.llvm.org/D18978 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D18978: Support Linux on SystemZ as platform

uweigand added a comment. In http://reviews.llvm.org/D18978#398180, @labath wrote: > Could you also add a core file test to `TestLinuxCore`? It should be a matter > of running `make_core.sh`, saving the files and creating a new test function > in the file (I've tried to make it simple, if you s

Re: [Lldb-commits] [PATCH] D18978: Support Linux on SystemZ as platform

labath added a comment. Could you also add a core file test to `TestLinuxCore`? It should be a matter of running `make_core.sh`, saving the files and creating a new test function in the file (I've tried to make it simple, if you see room for improvement, then let me know). I think this is espe

Re: [Lldb-commits] [PATCH] D18978: Support Linux on SystemZ as platform

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Ok, then setting write only watchpoints should be fine for those tests/ http://reviews.llvm.org/D18978 ___ lldb-commits mailing list lldb-com

Re: [Lldb-commits] [PATCH] D18978: Support Linux on SystemZ as platform

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Just a few questions on why read watchpoints were being disabled in the few SBValue::Watch() calls. Other than that it looks good. Is it possible to revert the read watchpoint ch