Re: [Lldb-commits] [PATCH] D18819: Reduce code duplication in ProcessGDBRemote

2016-04-06 Thread Ying Chen via lldb-commits
chying added a subscriber: chying. chying added a comment. TestRegisters.py and TestDebugBreak.py are broken after this change. Could you take a look? http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/13090 Repository: rL LLVM http://reviews.llvm.org/D18819 _

Re: [Lldb-commits] [PATCH] D18819: Reduce code duplication in ProcessGDBRemote

2016-04-06 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL265560: Reduce code duplication in ProcessGDBRemote (authored by labath). Changed prior to commit: http://reviews.llvm.org/D18819?vs=52773&id=52817#toc Repository: rL LLVM http://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D18819: Reduce code duplication in ProcessGDBRemote

2016-04-06 Thread Pavel Labath via lldb-commits
labath created this revision. labath added a reviewer: clayborg. labath added a subscriber: lldb-commits. SetThreadStopInfo was checking for a breakpoint at the current PC several times. This merges the identical code into a separate function. I've left one breakpoint check alone, as it was doin