This revision was automatically updated to reflect the committed changes.
Closed by commit rL265391: Fix a bug in linux core file handling (authored by
labath).
Changed prior to commit:
http://reviews.llvm.org/D18697?vs=52572&id=52679#toc
Repository:
rL LLVM
http://reviews.llvm.org/D18697
labath marked an inline comment as done.
labath added a comment.
I have also added a test which loads two core files with the same pid. (Based
on very little experimentation) everything seems to be working ok for that case.
Comment at: source/Plugins/Process/elf-core/ProcessElf
labath updated this revision to Diff 52572.
labath added a comment.
Address review comments.
http://reviews.llvm.org/D18697
Files:
include/lldb/Target/Process.h
packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/TestLinuxCore.py
packages/Python/lldbsuite/test/functional
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
See inlined comments.
Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:644-647
@@ +643,6 @@
+{
+info.Clear();
+info.SetProcessID(GetID());
What if you are simultaneously debugging 2 processes with the same pid?
Does this fail?
On Fri, Apr 1, 2016 at 9:06 AM Pavel Labath wrote:
> labath created this revision.
> labath added reviewers: clayborg, zturner.
> labath added a subscriber: lldb-commits.
>
> There was a bug in linux core file
labath created this revision.
labath added reviewers: clayborg, zturner.
labath added a subscriber: lldb-commits.
There was a bug in linux core file handling, where if there was a running
process with the same
process id as the id in the core file, the core file debugging would fail, as
we would
