Re: [Lldb-commits] [PATCH] D18689: Make FileSpec handling platform-independent

2016-04-04 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL265299: Make FileSpec handling platform-independent (authored by labath). Changed prior to commit: http://reviews.llvm.org/D18689?vs=52348&id=52556#toc Repository: rL LLVM http://reviews.llvm.org/D1

Re: [Lldb-commits] [PATCH] D18689: Make FileSpec handling platform-independent

2016-04-01 Thread Zachary Turner via lldb-commits
zturner added a comment. Ugh. The only better way I can think of to do this would be to go into LLVM and rip out all the preprocessor defines, and compile `_windows` and `_posix` versions of every function unconditionally, and then only use the preprocessor defines to do something like: #if

[Lldb-commits] [PATCH] D18689: Make FileSpec handling platform-independent

2016-04-01 Thread Pavel Labath via lldb-commits
labath created this revision. labath added a reviewer: zturner. labath added a subscriber: lldb-commits. Even though FileSpec attempted to handle both kinds of path syntaxes (posix and windows) on both platforms, it relied on the llvm path library to do its work, whose behavior differed on diffe