Re: [Lldb-commits] [PATCH] D18598: Don't vary debug info for lldb-server tests

2016-03-31 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL265017: Don't vary debug info for lldb-server tests (authored by labath). Changed prior to commit: http://reviews.llvm.org/D18598?vs=52058&id=52203#toc Repository: rL LLVM http://reviews.llvm.org/D1

Re: [Lldb-commits] [PATCH] D18598: Don't vary debug info for lldb-server tests

2016-03-31 Thread Tamas Berghammer via lldb-commits
tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. Looks good (I don't like the syntax with a class level variable but don't know any better one as using decorators for this would be very difficult) http://reviews.llvm.org/D18598

Re: [Lldb-commits] [PATCH] D18598: Don't vary debug info for lldb-server tests

2016-03-30 Thread Todd Fiala via lldb-commits
LGTM, thanks for getting to that, Pavel! On Wednesday, March 30, 2016, Pavel Labath wrote: > labath created this revision. > labath added reviewers: tberghammer, tfiala. > labath added a subscriber: lldb-commits. > > Debug info is used only by the client and lldb-server tests do not even > have

[Lldb-commits] [PATCH] D18598: Don't vary debug info for lldb-server tests

2016-03-30 Thread Pavel Labath via lldb-commits
labath created this revision. labath added reviewers: tberghammer, tfiala. labath added a subscriber: lldb-commits. Debug info is used only by the client and lldb-server tests do not even have the client component running, as they communicate with the server directly. Therefore, running the test