Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

This revision was automatically updated to reflect the committed changes. Closed by commit rL264685: Move some functions from DWARFASTParserClang to ClangASTImporter. (authored by zturner). Changed prior to commit: http://reviews.llvm.org/D18381?vs=51705&id=51848#toc Repository: rL LLVM htt

Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

zturner added a comment. Hi Greg, are you going to have a chance to try this out today? http://reviews.llvm.org/D18381 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

zturner updated this revision to Diff 51705. zturner added a comment. Rebased against ToT http://reviews.llvm.org/D18381 Files: include/lldb/Symbol/ClangASTContext.h include/lldb/Symbol/ClangASTImporter.h include/lldb/Symbol/ClangUtil.h include/lldb/Symbol/TypeSystem.h source/Plugins/

Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

Did you get a chance to test this today? On Fri, Mar 25, 2016 at 9:32 AM Greg Clayton wrote: > Will do. > > On Mar 24, 2016, at 3:30 PM, Zachary Turner wrote: > > > > Is there any way you could try it out for me? It still doesn't build > successfully from the IDE with those steps. > > > > The

Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

Will do. > On Mar 24, 2016, at 3:30 PM, Zachary Turner wrote: > > Is there any way you could try it out for me? It still doesn't build > successfully from the IDE with those steps. > > The patch should apply cleanly at tip. Later this week I can try to nuke my > whole lldb directory and s

Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

Is there any way you could try it out for me? It still doesn't build successfully from the IDE with those steps. The patch should apply cleanly at tip. Later this week I can try to nuke my whole lldb directory and start over with a clean repo. On Thu, Mar 24, 2016 at 3:26 PM Greg Clayton wrote

Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

You might need to set your workspace settings for the lldb.xcworkspace as follows: File -> Workspace Settings... Derived Data: Workspace-relative Location and use the value "build" for it Then click the "Advanced..." button and select "Legacy". The test suite automatically looks in the lldb

Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

Figured as much. Thanks for the tip. Back to the issue of the test suite, I ran the test suite but I get a ton of errors in Objective C tests even without my patch applied. So I must still be doing something worng. I used the xcodebuild command line, then ran `test/dotest.py` with no arguments.

Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

Once per login session. You may also need to run: sudo /usr/sbin/DevToolsSecurity --enable if you've never debugged anything before. You should only need to do this once per clean OS install. Jim > On Mar 24, 2016, at 2:53 PM, Zachary Turner via lldb-commits > wrote: > > Is it one time un

Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

> On Mar 24, 2016, at 2:53 PM, Zachary Turner wrote: > > Is it one time until I reboot, or until the end of the test suite? > The former. > On Thu, Mar 24, 2016 at 2:51 PM Enrico Granata > wrote: >> On Mar 24, 2016, at 2:44 PM, Zachary Turner via lldb-commits >> m

Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

Is it one time until I reboot, or until the end of the test suite? On Thu, Mar 24, 2016 at 2:51 PM Enrico Granata wrote: > On Mar 24, 2016, at 2:44 PM, Zachary Turner via lldb-commits < > lldb-commits@lists.llvm.org> wrote: > > It's updated now. I'm still getting errors building from inside Xco

Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

> On Mar 24, 2016, at 2:44 PM, Zachary Turner via lldb-commits > wrote: > > It's updated now. I'm still getting errors building from inside Xcode when I > use the IDE, but it works from the command line. But running the test pops > up hundreds of dialogs asking me to enter my password to ta

Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

It's updated now. I'm still getting errors building from inside Xcode when I use the IDE, but it works from the command line. But running the test pops up hundreds of dialogs asking me to enter my password to take control of another process, so I'm not sure how to disable that. Anyway I updated

Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

zturner updated this revision to Diff 51605. zturner added a comment. Update patch. http://reviews.llvm.org/D18381 Files: include/lldb/Symbol/ClangASTContext.h include/lldb/Symbol/ClangASTImporter.h include/lldb/Symbol/ClangUtil.h include/lldb/Symbol/TypeSystem.h source/Plugins/Expres

Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

I usually select "desktop" as the target. Is this patch up to date? If so, I can apply and compile it and let you know what the results are. > On Mar 24, 2016, at 2:21 PM, Zachary Turner wrote: > > Yes I was doing it from inside the IDE though. I selected lldb-tool, 64-bit, > and hit Product

Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

Yes I was doing it from inside the IDE though. I selected lldb-tool, 64-bit, and hit Product -> Build On Thu, Mar 24, 2016 at 2:11 PM Greg Clayton wrote: > You you building with Xcode? You should be building by checking out lldb > at the top level, then typing: > > % xcodebuild -configuration D

Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

You you building with Xcode? You should be building by checking out lldb at the top level, then typing: % xcodebuild -configuration Debug > On Mar 24, 2016, at 12:31 PM, Zachary Turner wrote: > > Having trouble building on OSX. > > ERROR:root:Unable to find swig executable: 'module' object h

Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

Having trouble building on OSX. ERROR:root:Unable to find swig executable: 'module' object has no attribute 'OSError' Command /bin/sh failed with exit code 250 But "which swig" finds it just fine. It's been a long time since I've built on OSX so I don't know if something has changed. In any c

Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

zturner added a comment. It's been a while since I've used my Mac. I'll fire it up and see if I can get it going, but no promises. I'll update tomorrow http://reviews.llvm.org/D18381 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http:

Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

clayborg added a comment. I will need to run the MacOSX test suite on this before I can give it the OK. I won't be able to do this today, but might be able to get to it tomorrow. If you can run the MacOSX test suite, let me know. http://reviews.llvm.org/D18381 __

Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

zturner updated this revision to Diff 51480. zturner added a comment. Fixes issue with `CanCompleteType` being unimplemented. This update deletes `CanCompleteType` and `CompleteType` from `DWARFASTParser` base class, and users of that function now call `GetClangASTImporter().CanImport()` and `

Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

zturner added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1614-1622 @@ -1611,9 +1613,11 @@ TypeSystem *type_system = compiler_type.GetTypeSystem(); -if (type_system) -{ -DWARFASTParser *dwarf_ast = type_system->GetDWARFPars

Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. A few things in inlined comments, but this is very close. Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParser.h:36 @@ -35,3 +35,3 @@ virtual bool -

Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

zturner updated this revision to Diff 51476. zturner added a comment. This patch has gotten both bigger and smaller. Smaller in the sense that after taking into consideration the most recent comments, there was really only one piece left of my patch. It is the piece that abstracted out `CanCom

Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

clayborg added a comment. I In http://reviews.llvm.org/D18381#381457, @zturner wrote: > I guess my point was just that it seems a little weird to treat DWARF > specially. It's just another debug info format (albeit one that most > compilers support), so by baking into the supposedly generic i

Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

zturner added a comment. I guess my point was just that it seems a little weird to treat DWARF specially. It's just another debug info format (albeit one that most compilers support), so by baking into the supposedly generic interface the requirement that "every type system must be able to sup

Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

clayborg added a comment. No. Keep GetDWARFParser() on TypeSystem and all that code as is. You shouldn't need to add GetPDBParser() to TypeSystem as you should get a type system for language from within your SymbolFilePDB (with a language like C or C++) and then make a PDBParser with a referenc

Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

Should we go back to my original patch then? It left the parser accessible from TypeSystem, but made it a DebugInfoParser instead of a DWARFParser. The whole idea is to remove knowledge of a specific debug info format from the generic TypeSystem, so it still seems wrong to add DWARF specific stuff

Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. After our last conversation I must have missed that both Go and Java need to be able to provide custom DWARF parsing. Any language, and any TypeSystem, should be able to provide

[Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

zturner created this revision. zturner added a reviewer: clayborg. zturner added a subscriber: lldb-commits. This patch attempts to remove the coupling between `ClangASTContext` and DWARF debug information. Previously, `TypeSystem` exposed a method called `GetDWARFParser`, which means that any