clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good. Thanks for all the fixes.
http://reviews.llvm.org/D18379
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.l
sivachandra added inline comments.
Comment at: source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp:110-119
@@ -80,3 +109,12 @@
-} // anonymous namespace end
+template
+T
+Align(const T v, uint8_t bytes)
+{
+uint8_t rem = v % bytes;
+if (rem == 0)
+
sivachandra updated this revision to Diff 51466.
sivachandra added a comment.
Address comments.
http://reviews.llvm.org/D18379
Files:
source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp
source/Plugins/JITLoader/GDB/JITLoaderGDB.h
Index: source/Plugins/JITLoader/GDB/JITLoaderGDB.h
===
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
See inlined comments.
Comment at: source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp:110-119
@@ -80,3 +109,12 @@
-} // anonymous namespace end
+template
+
sivachandra added a comment.
How does this look?
http://reviews.llvm.org/D18379
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
sivachandra updated this revision to Diff 51370.
sivachandra added a comment.
Modify according to suggestions.
http://reviews.llvm.org/D18379
Files:
source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp
source/Plugins/JITLoader/GDB/JITLoaderGDB.h
Index: source/Plugins/JITLoader/GDB/JITLoaderGDB.h
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
One thing to note: don't use Process::DoReadMemory(), it doesn't cache data and
it will always result in a read memory packet going to GDB server if you are
using lldb-server and
sivachandra created this revision.
sivachandra added a reviewer: clayborg.
sivachandra added a subscriber: lldb-commits.
Though r264012 was fancy enough to make reading the jit entry struct
work with templates, the packing and alignment attributes do not work on
Windows. So, this change makes it p
