Re: [Lldb-commits] [PATCH] D18194: Abstract the debug info parser from the ASTContext

2016-03-22 Thread Zachary Turner via lldb-commits
zturner abandoned this revision. zturner added a comment. Abandoning this revision and will re-open a new revision. http://reviews.llvm.org/D18194 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

Re: [Lldb-commits] [PATCH] D18194: Abstract the debug info parser from the ASTContext

2016-03-21 Thread Greg Clayton via lldb-commits
clayborg added a comment. I need to speak with you about this and I do have objections. I made a ton of comments inline and as I started to understand what you were trying to do many objections changed, but I still have them. There is a ton of stuff in there and I would like to speak with you o

Re: [Lldb-commits] [PATCH] D18194: Abstract the debug info parser from the ASTContext

2016-03-21 Thread Zachary Turner via lldb-commits
zturner added a comment. ping, any objections here Greg? http://reviews.llvm.org/D18194 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D18194: Abstract the debug info parser from the ASTContext

2016-03-19 Thread Zachary Turner via lldb-commits
zturner updated this revision to Diff 50840. zturner added a comment. Re-opening this after an update. I had to move `CanCompleteType`, `CompleteType`, and `LayoutRecordType` implementations into another class (which I've called `ClangTypeImportHelper`, because PDB needed to use the exact same

Re: [Lldb-commits] [PATCH] D18194: Abstract the debug info parser from the ASTContext

2016-03-15 Thread Zachary Turner via lldb-commits
zturner abandoned this revision. zturner added a comment. Abandoning this for now, I ran into some difficulties when trying to implement the PDB version. Will have to resolve those first and then come back to this. http://reviews.llvm.org/D18194 _

[Lldb-commits] [PATCH] D18194: Abstract the debug info parser from the ASTContext

2016-03-15 Thread Zachary Turner via lldb-commits
zturner created this revision. zturner added a reviewer: clayborg. zturner added a subscriber: lldb-commits. ClangASTContext was assuming the presence of DWARF debug info, so it was baked into the class that DWARFASTParserClang would be used. This won't be the case with PDB, which will need a P