This revision was automatically updated to reflect the committed changes.
Closed by commit rL264173: Implement ObjectFilePECOFF::GetEntryPointAddress.
(authored by sas).
Changed prior to commit:
http://reviews.llvm.org/D17970?vs=50978&id=51449#toc
Repository:
rL LLVM
http://reviews.llvm.org
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D17970
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
sas updated this revision to Diff 50978.
sas added a comment.
Change implementation according to @clayborg's comments.
http://reviews.llvm.org/D17970
Files:
source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h
Index: source/Plugins/Objec
sas added a comment.
Yep, @jingham is right, I need this for expression evaluation. I'll do the
change @clayborg requested.
http://reviews.llvm.org/D17970
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
sas added a comment.
FWIW, I didn't cache this value because in the current form it is just
returning some data that is already cached by `ParseHeader()`. If I split it in
section/offset address, it might be required.
http://reviews.llvm.org/D17970
__
I was hoping there would be something like `image headers` that would just
display various information about the image, but it looks like we don't
have such a command that I can find. Seems like being able to find out the
entry point of a certain module would be useful.
On Tue, Mar 8, 2016 at 4:0
zturner added a subscriber: zturner.
zturner added a comment.
I was hoping there would be something like `image headers` that would just
display various information about the image, but it looks like we don't
have such a command that I can find. Seems like being able to find out the
entry point o
jingham added a subscriber: jingham.
jingham added a comment.
We use the entry point address as the place to stop when we call functions by
hand in the target. That's one place which is legit TEXT, but we are pretty
sure the code you are calling will never call. So if the entry point address
We use the entry point address as the place to stop when we call functions by
hand in the target. That's one place which is legit TEXT, but we are pretty
sure the code you are calling will never call. So if the entry point address
isn't set correctly we probably won't be able to call any funct
clayborg added a comment.
lldb_private::Address is a section offset address class. We use section offset
addresses everywhere. We also have the notion of three types of addresses: file
address, load address and host address.
File addresses are virtual addresses as they are found in the object f
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
ObjectFilePECOFF::GetEntryPointAddress() is not implemented correctly. See
inlined comments.
Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:8
zturner added a comment.
Looks pretty non-controversial. Does this fix anything? Seems like there
should be a test that breaks somehow if this doesn't work. I don't know off
the top of my head what the debugger command is "get the address of the entry
point", but presumably it was broken bef
sas created this revision.
sas added reviewers: zturner, clayborg.
sas added a subscriber: lldb-commits.
http://reviews.llvm.org/D17970
Files:
source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h
Index: source/Plugins/ObjectFile/PECOFF/Obj
13 matches
Mail list logo
