[Lldb-commits] [PATCH] D17957: Expression evaluation for overloaded C functions

2016-11-29 Thread Luke Drummond via Phabricator via lldb-commits
ldrumm added a comment. New candidate is here Repository: rL LLVM https://reviews.llvm.org/D17957 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm

[Lldb-commits] [PATCH] D17957: Expression evaluation for overloaded C functions

2016-11-29 Thread Ewan Crawford via Phabricator via lldb-commits
EwanCrawford abandoned this revision. EwanCrawford added a subscriber: ldrumm. EwanCrawford added a comment. Abandoning this patch since it's out of date, and @ldrumm has an alternative fix he's about to post Repository: rL LLVM https://reviews.llvm.org/D17957

Re: [Lldb-commits] [PATCH] D17957: Expression evaluation for overloaded C functions

2016-03-21 Thread Ewan Crawford via lldb-commits
EwanCrawford updated this revision to Diff 51182. EwanCrawford added a comment. Rebased on tip Repository: rL LLVM http://reviews.llvm.org/D17957 Files: packages/Python/lldbsuite/test/expression_command/call-overloaded-c-fuction/Makefile packages/Python/lldbsuite/test/expression_comman

Re: [Lldb-commits] [PATCH] D17957: Expression evaluation for overloaded C functions

2016-03-14 Thread Ewan Crawford via lldb-commits
EwanCrawford added inline comments. Comment at: packages/Python/lldbsuite/test/expression_command/call-overloaded-c-fuction/Makefile:8 @@ +7,2 @@ +clean:: + rm -rf $(wildcard *.o *.d *.dSYM) labath wrote: > clayborg wrote: > > Maybe we can have a standard c

Re: [Lldb-commits] [PATCH] D17957: Expression evaluation for overloaded C functions

2016-03-14 Thread Pavel Labath via lldb-commits
labath added a subscriber: labath. Comment at: packages/Python/lldbsuite/test/expression_command/call-overloaded-c-fuction/Makefile:8 @@ +7,2 @@ +clean:: + rm -rf $(wildcard *.o *.d *.dSYM) clayborg wrote: > Maybe we can have a standard clean rule in the ma

Re: [Lldb-commits] [PATCH] D17957: Expression evaluation for overloaded C functions

2016-03-14 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. Comment at: packages/Python/lldbsuite/test/expression_command/call-overloaded-c-fuction/Makefile:8 @@ +7,2 @@ +clean:: + rm -rf $(wildcard *.o *.d *.dSYM) Maybe we can have a standard clean rule in the main makefiles: stand

Re: [Lldb-commits] [PATCH] D17957: Expression evaluation for overloaded C functions

2016-03-14 Thread Ewan Crawford via lldb-commits
EwanCrawford updated this revision to Diff 50595. EwanCrawford added a comment. Thanks for taking a look Sean. I moved the mangling logic into `LanguageCPlusPlus` and created a new method for it. There was an existing function `FindEquivalentNames` that used `CPPRuntimeEquivalents`, but looked

Re: [Lldb-commits] [PATCH] D17957: Expression evaluation for overloaded C functions

2016-03-11 Thread Sean Callanan via lldb-commits
spyffe added a reviewer: clayborg. spyffe added a comment. Added Greg to look at the testsuite changes. Repository: rL LLVM http://reviews.llvm.org/D17957 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

Re: [Lldb-commits] [PATCH] D17957: Expression evaluation for overloaded C functions

2016-03-11 Thread Sean Callanan via lldb-commits
spyffe requested changes to this revision. spyffe added a comment. This revision now requires changes to proceed. There are a few changes I'd recommend to this patch. The biggest one is to move mangling knowledge from IRExecutionUnit to LanguageCPlusPlus, where it logically fits better. The tes

Re: [Lldb-commits] [PATCH] D17957: Expression evaluation for overloaded C functions

2016-03-11 Thread Greg Clayton via lldb-commits
clayborg resigned from this revision. clayborg removed a reviewer: clayborg. clayborg added a comment. I will let Sean Callanan review this one as the expression parser is his area. Repository: rL LLVM http://reviews.llvm.org/D17957 ___ lldb-comm

Re: [Lldb-commits] [PATCH] D17957: Expression evaluation for overloaded C functions

2016-03-11 Thread Ewan Crawford via lldb-commits
EwanCrawford added a comment. friendly ping Repository: rL LLVM http://reviews.llvm.org/D17957 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D17957: Expression evaluation for overloaded C functions

2016-03-08 Thread Ewan Crawford via lldb-commits
EwanCrawford created this revision. EwanCrawford added reviewers: spyffe, clayborg. EwanCrawford added a subscriber: lldb-commits. EwanCrawford set the repository for this revision to rL LLVM. Fixes bugzilla ticket https://llvm.org/bugs/show_bug.cgi?id=26694 Where we can currently pick the incorre