This revision was automatically updated to reflect the committed changes.
Closed by commit rL261345: refactor/cleanup ClangExpressionParser::Parse
(authored by EwanCrawford).
Changed prior to commit:
http://reviews.llvm.org/D17273?vs=48002&id=48507#toc
Repository:
rL LLVM
http://reviews.llv
spyffe accepted this revision.
spyffe added a comment.
This revision is now accepted and ready to land.
Aside from a minor nit, this looks like good cleanup. If it passes the
testsuite, feel free to commit after addressing the inline comment.
Comment at: source/Plugins/Express
clayborg resigned from this revision.
clayborg removed a reviewer: clayborg.
clayborg added a comment.
I will let Sean Callanan OK this one.
http://reviews.llvm.org/D17273
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.o
ldrumm created this revision.
ldrumm added reviewers: clayborg, zturner, spyffe.
ldrumm added a subscriber: lldb-commits.
- fix return type: `ClangExpressionParser::Parse` returns unsigned, but was
actually returning a signed value, `num_errors`.
- use helper `clang::TextDiagnosticBuffer::get
