Re: [Lldb-commits] [PATCH] D17106: Fix SocketTest on Windows

2016-03-20 Thread Zachary Turner via lldb-commits
Yea that works On Wed, Mar 16, 2016 at 6:33 AM Pavel Labath wrote: > labath added a comment. > > So I ran the tests on windows (http://reviews.llvm.org/W7 Enterprise) now > and I did indeed get the long "0:0:...:1" version here instead of "::1". > Maybe we should just accept both versions as corr

Re: [Lldb-commits] [PATCH] D17106: Fix SocketTest on Windows

2016-03-20 Thread Pavel Labath via lldb-commits
labath added a comment. So I ran the tests on windows (http://reviews.llvm.org/W7 Enterprise) now and I did indeed get the long "0:0:...:1" version here instead of "::1". Maybe we should just accept both versions as correct? Repository: rL LLVM http://reviews.llvm.org/D17106

Re: [Lldb-commits] [PATCH] D17106: Fix SocketTest on Windows

2016-02-18 Thread Zachary Turner via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL261240: Fix SocketTest on Windows. (authored by zturner). Changed prior to commit: http://reviews.llvm.org/D17106?vs=47537&id=48360#toc Repository: rL LLVM http://reviews.llvm.org/D17106 Files: ll

Re: [Lldb-commits] [PATCH] D17106: Fix SocketTest on Windows

2016-02-12 Thread Pavel Labath via lldb-commits
labath added a subscriber: labath. labath accepted this revision. labath added a reviewer: labath. labath added a comment. This revision is now accepted and ready to land. We are not running these unittests on windows at the moment. You are the windows maintainer, so if you say this is working fo

[Lldb-commits] [PATCH] D17106: Fix SocketTest on Windows

2016-02-10 Thread Zachary Turner via lldb-commits
zturner created this revision. zturner added a reviewer: vharron. zturner added a subscriber: lldb-commits. Hi Vince, I'm not sure why the #if _WIN32 check is even in there to begin with, but I tested on Windows 7 and Windows 10 and in both cases the output is that of the non _WIN32 path. Were