This revision was automatically updated to reflect the committed changes.
Closed by commit rL260135: A number of improvements to decorator conditionals.
(authored by zturner).
Changed prior to commit:
http://reviews.llvm.org/D16938?vs=47068&id=47233#toc
Repository:
rL LLVM
http://reviews.ll
tfiala accepted this revision.
tfiala added a comment.
LGTM.
Regarding the section Pavel was looking at, on the Apple side we have a
simulator target that is not technically remote, but isn't really local either.
I'll have to look at that if/when we actually want to mark a simulator test as
f
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks good, after applying one fix.
Comment at: packages/Python/lldbsuite/test/decorators.py:148
@@ +147,3 @@
+skip_for_triple = _match_decorator_property(triple,
lld
tfiala added a comment.
I'll have a look at this after I get through http://reviews.llvm.org/D16936.
Concept sounds great.
http://reviews.llvm.org/D16938
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
zturner updated this revision to Diff 47068.
zturner added a comment.
Minor change that allows any iterable to be used (not just lists), and also
recurses through the `_match_decorator_property` function for each item in the
iterable, instead of just doing a simple list membership. Combined wit
zturner created this revision.
zturner added reviewers: tfiala, labath, tberghammer.
zturner added a subscriber: lldb-commits.
The goal here is to try to improve consistency across the variety of decorators
we support. This patch makes the following changes:
* Change the `not_in` function to be
