Re: [Lldb-commits] [PATCH] D16872: Move some of the common decorators to decorators.py

2016-03-10 Thread Todd Fiala via lldb-commits
tfiala accepted this revision. tfiala added a comment. This happened, right? Can we close? http://reviews.llvm.org/D16872 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D16872: Move some of the common decorators to decorators.py

2016-02-04 Thread Tamas Berghammer via lldb-commits
tberghammer accepted this revision. tberghammer added a comment. Looks reasonable Comment at: packages/Python/lldbsuite/test/lldbtest.py:672-682 @@ -768,1 +671,13 @@ + +def skipUnlessListedRemote(remote_list=None): +def is_remote_unlisted(self): +if remote_list and l

Re: [Lldb-commits] [PATCH] D16872: Move some of the common decorators to decorators.py

2016-02-04 Thread Pavel Labath via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I think it's a good idea. I haven't given it a spin, but I think we can fix up any breakages from this on the fly. http://reviews.llvm.org/D16872 __

Re: [Lldb-commits] [PATCH] D16872: Move some of the common decorators to decorators.py

2016-02-03 Thread Zachary Turner via lldb-commits
zturner added a comment. Perhaps one possibility to avoid the massive changes to every test file required by changes like this is to make a module like `test_imports.py`, and have that file import all of these things, and then have each test just import `test_imports`. That way we don't have t

[Lldb-commits] [PATCH] D16872: Move some of the common decorators to decorators.py

2016-02-03 Thread Zachary Turner via lldb-commits
zturner created this revision. zturner added reviewers: labath, tberghammer, tfiala. zturner added a subscriber: lldb-commits. Herald added subscribers: srhines, danalbert, tberghammer. This creates the `decorators.py` module and moves some of the low level common decorators there. There are man