This revision was automatically updated to reflect the committed changes.
Closed by commit rL260362: [LLDB][MIPS] Generalise MIPS arch names (authored by
mohit.bhakkad).
Changed prior to commit:
http://reviews.llvm.org/D16840?vs=46919&id=47423#toc
Repository:
rL LLVM
http://reviews.llvm.org
nitesh.jain updated this revision to Diff 46919.
nitesh.jain added a comment.
updates diff with triple =re.compile('^mips') to check if architecture string
starts with mips.
Repository:
rL LLVM
http://reviews.llvm.org/D16840
Files:
packages/Python/lldbsuite/test/functionalities/thread/cr
nitesh.jain updated the summary for this revision.
nitesh.jain updated this revision to Diff 46913.
nitesh.jain added a comment.
Updated as per the suggestion.
Repository:
rL LLVM
http://reviews.llvm.org/D16840
Files:
packages/Python/lldbsuite/test/functionalities/thread/crash_during_step
nitesh.jain marked an inline comment as done.
Comment at:
packages/Python/lldbsuite/test/functionalities/thread/crash_during_step/TestCrashDuringStep.py:24
@@ -23,3 +23,3 @@
@expectedFailureAndroid("llvm.org/pr24497", archs=['arm', 'aarch64'])
-@expectedFailureAll(archs=
zturner added a comment.
Correction: If he's using expectedFailureAll, only the 'triple=' keyword
will take a regex.
Repository:
rL LLVM
http://reviews.llvm.org/D16840
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.or
I know this is super confusing but `expectedFailureAll` doesn't yet support
regular expressions. I'm working on this code as we speak, so it will
soon. But what you're probably thinking of is `skipUnlessArch` (but
ironically not `skipIfArch` or `expectedFailureArch`). AH.
Anyway, that's
clayborg accepted this revision.
clayborg added a comment.
I believe we recently switched "archs" so that we auto detect the type so you
could use a regular expression. See above inlined comments.
Good to go unless you want to adopt any of my inlined suggestions.
Comment at:
Looks fine to me
On Tue, Feb 2, 2016 at 11:57 PM Nitesh Jain wrote:
> nitesh.jain updated this revision to Diff 46750.
> nitesh.jain added a comment.
>
> Update the diff with suggested changes
>
>
> Repository:
> rL LLVM
>
> http://reviews.llvm.org/D16840
>
> Files:
>
> packages/Python/lldbsui
nitesh.jain updated this revision to Diff 46750.
nitesh.jain added a comment.
Update the diff with suggested changes
Repository:
rL LLVM
http://reviews.llvm.org/D16840
Files:
packages/Python/lldbsuite/test/functionalities/thread/crash_during_step/TestCrashDuringStep.py
packages/Python/
nitesh.jain added a comment.
Thanks zturner.
The triple is match using re.match(triple,
lldb.DBG.GetSelectedPlatform().GetTriple()).
I will update diff with the suggested changes.
Repository:
rL LLVM
http://reviews.llvm.org/D16840
___
lldb-co
zturner added a subscriber: zturner.
zturner added a comment.
Are you sure the triple keyword parameter supports this syntax? It doesn't
appear to be a regex since you're matching "mips*" instead of "mips.*". I
believe the regular string matching algorithm uses the python `in` keyword
(which doe
Are you sure the triple keyword parameter supports this syntax? It doesn't
appear to be a regex since you're matching "mips*" instead of "mips.*". I
believe the regular string matching algorithm uses the python `in` keyword
(which does a substring check), so just saying `triple = "mips"` should
w
jaydeep accepted this revision.
jaydeep added a comment.
This revision is now accepted and ready to land.
Looks good to me
Repository:
rL LLVM
http://reviews.llvm.org/D16840
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.l
nitesh.jain created this revision.
nitesh.jain added a reviewer: jaydeep.
nitesh.jain added subscribers: bhushan, sagar, mohit.bhakkad, lldb-commits.
nitesh.jain set the repository for this revision to rL LLVM.
For mips there are more subarchs like mips32r2, mips32r6. This patch uses
re.match("mi
14 matches
Mail list logo
