This revision was automatically updated to reflect the committed changes.
zturner marked 3 inline comments as done.
Closed by commit rL259543: Re-write many skip decorators to use shared code.
(authored by zturner).
Changed prior to commit:
http://reviews.llvm.org/D16741?vs=46599&id=46677#toc
labath added inline comments.
Comment at: packages/Python/lldbsuite/test/lldbtest.py:1102
@@ -1164,2 +1101,3 @@
+return func(*args, **kwargs)
return wrapper
zturner wrote:
> labath wrote:
> > zturner wrote:
> > > labath wrote:
> > > > Th
zturner added a comment.
> If we haven't already, we should probably have some kind of exception wrapper
> around our decorators that catches non-unittest-related (i.e. unexpected)
> exceptions and somehow makes them more prevalent - maybe a hard error on the
> test or an abort or something.
labath added a comment.
> If we haven't already, we should probably have some kind of exception
> wrapper around our decorators that catches non-unittest-related (i.e.
> unexpected) exceptions and somehow makes them more prevalent - maybe a hard
> error on the test or an abort or something.
> We've already had a case when a test wasn't running for several months
before I noticed (see r257901) that it had a bad decorator applied at the
class level.
I've been thinking about this in the background lately. Several times over
the last couple years I found decorator logic that had errors
tfiala added a comment.
> We've already had a case when a test wasn't running for several months
before I noticed (see r257901) that it had a bad decorator applied at the
class level.
I've been thinking about this in the background lately. Several times over
the last couple years I found decor
zturner added inline comments.
Comment at: packages/Python/lldbsuite/test/lldbtest.py:1102
@@ -1164,2 +1101,3 @@
+return func(*args, **kwargs)
return wrapper
labath wrote:
> This return statement is the root cause of the problem. If `fun
labath added a comment.
LGTM from my side after the two fixes in `no_debug_info_test` and
`skipUnlessListedRemote`
Comment at: packages/Python/lldbsuite/test/lldbtest.py:555
@@ -554,3 +554,3 @@
# Mark this function as such to separate them from the regular tests.
-wrap
I'll see if I can run this tonight. If not tonight, I'll do it first
thing in the morning.
On Mon, Feb 1, 2016 at 5:17 PM, Zachary Turner wrote:
> zturner updated this revision to Diff 46599.
> zturner added a comment.
> Herald added subscribers: srhines, danalbert, tberghammer.
>
> I think th
tfiala added a subscriber: tfiala.
tfiala added a comment.
I'll see if I can run this tonight. If not tonight, I'll do it first
thing in the morning.
http://reviews.llvm.org/D16741
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://l
zturner updated this revision to Diff 46599.
zturner added a comment.
Herald added subscribers: srhines, danalbert, tberghammer.
I think this should fix most of the issues. A few of the decorators I wasn't
able to touch because of the issues with class-level decorators. But I think
this is a g
zturner marked an inline comment as done.
zturner added a comment.
I guess we need to be consistent. Do we want to be able to decorate entire
classes, or not? If we do, then we should remove the check. If we don't then
we should leave the check. But since many tests are already using these
zturner marked an inline comment as done.
Comment at: packages/Python/lldbsuite/test/lldbtest.py:560
@@ -559,3 +559,1 @@
"""Decorate the item as a debugserver test."""
-if isinstance(func, type) and issubclass(func, unittest2.TestCase):
-raise Exception("@debugser
labath added a comment.
I am confused as to how could this even work, since all your decorators seem to
be ignoring the function they are decorating. I'm pretty sure this is going to
cause some very weird things to happen things to come out of the decoration
process, which might explain your co
zturner created this revision.
zturner added reviewers: labath, tberghammer, tfiala.
zturner added a subscriber: lldb-commits.
Trying to reduce the complexity of all our decorators, I decided to make most
of them use `skipTestIfFn`. Unfortunately there's some issues with my patch.
I'm not real
15 matches
Mail list logo
