tfiala added a comment.
Skipped TestWatchLocation.py test method on OS X with r259526 while I
investigate.
Repository:
rL LLVM
http://reviews.llvm.org/D16736
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
tfiala added a comment.
In http://reviews.llvm.org/D16736#341705, @tfiala wrote:
> This change appears to have caused a test error (rather than a test failure)
> on the OS X builder.
It's not clear to me yet why I didn't see this at home, but my first guess is
that I have all my consoles set
tfiala added a comment.
This change appears to have caused a test error (rather than a test failure) on
the OS X builder. See here (master builder step):
http://lab.llvm.org:8080/green/job/LLDB/16318/
and here (build and test run step):
http://lab.llvm.org:8080/green/job/lldb_build_test/16209/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL259379: Always write the session file in UTF-8. (authored by
zturner).
Changed prior to commit:
http://reviews.llvm.org/D16736?vs=46426&id=46556#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1673
tfiala added a subscriber: tfiala.
tfiala added a comment.
Just that x command needs to be commented out. The m command is fine as is.
-Todd
http://reviews.llvm.org/D16736
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.
Just that x command needs to be commented out. The m command is fine as is.
-Todd
> On Feb 1, 2016, at 5:03 AM, Pavel Labath wrote:
>
> labath added a comment.
>
> TestGDBRemoteMemoryRead.py is my test and I gotta admit it is somewhat
> hackish. If this is the only issue that is stopping this
labath added a comment.
TestGDBRemoteMemoryRead.py is my test and I gotta admit it is somewhat hackish.
If this is the only issue that is stopping this from going through, then please
xfail it, and i'll rewrite it in some other way.
http://reviews.llvm.org/D16736
___
tfiala added a comment.
In fact I'd say you could do this, now that I've looked at the test:
diff --git
a/packages/Python/lldbsuite/test/tools/lldb-server/TestGDBRemoteMemoryRead.py
b/packages/Python/lldbsuite/test/tools/lldb-server/TestGDBRemoteMemoryRead.py
index 7b974e5..9f80abe 100644
tfiala added a comment.
In http://reviews.llvm.org/D16736#340302, @tfiala wrote:
> In any event, the right fix here probably is to have displays of
> matched/expected text for known-to-be binary data *not* try to print results
> in the expect-string-match code since these are just going to have
tfiala added a comment.
> I'm going to have a look at trying this modification now.
I'm getting the same error with the replace.
Here is the patch (okay the whole encoded_file.py) I was able to use to get
past this - which ultimately looks to be an error in the match result printing
of a raw
tfiala added a comment.
In http://reviews.llvm.org/D16736#339925, @tfiala wrote:
> In http://reviews.llvm.org/D16736#339889, @zturner wrote:
>
> > Hmm, that almost looks to me like it's finding a real bug. Which it
> > probably is, because higher up the callstack it's reading the response of a
tfiala added a comment.
In http://reviews.llvm.org/D16736#339889, @zturner wrote:
> Hmm, that almost looks to me like it's finding a real bug. Which it
> probably is, because higher up the callstack it's reading the response of a
> memory send. I'm guessing that the response includes non-prin
Hmm, that almost looks to me like it's finding a real bug. Which it
probably is, because higher up the callstack it's reading the response of a
memory send. I'm guessing that the response includes non-printable
characters (raw memory data) that wasn't being written before but was being
silently i
zturner added a subscriber: zturner.
zturner added a comment.
Hmm, that almost looks to me like it's finding a real bug. Which it
probably is, because higher up the callstack it's reading the response of a
memory send. I'm guessing that the response includes non-printable
characters (raw memory
tfiala added a comment.
The only test I see fail with this is:
TestGDBRemoteMemoryRead.py:
ERROR: test_memory_read_dwarf (TestGDBRemoteMemoryRead.MemoryReadTestCase)
--
Traceback (most recent call last):
File
"/Users/
tfiala added a comment.
Running the test suite now. So far so good (it didn't blow up immediately like
it has for other attempts). I'll post back when the test run completes.
http://reviews.llvm.org/D16736
___
lldb-commits mailing list
lldb-commi
tfiala added a comment.
I'll give it a run!
http://reviews.llvm.org/D16736
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner created this revision.
zturner added reviewers: tfiala, labath, tberghammer.
zturner added a subscriber: lldb-commits.
Herald added a subscriber: aemerson.
Hopefully the 10th time's a charm on this one.
This patch attempts to solve the Python 2 / Python 3 incompatibilities by
introduci
18 matches
Mail list logo
