This revision was automatically updated to reflect the committed changes.
Closed by commit rL259356: Remove Timer::Initialize routine (authored by
labath).
Changed prior to commit:
http://reviews.llvm.org/D16722?vs=46380&id=46524#toc
Repository:
rL LLVM
http://reviews.llvm.org/D16722
Files
labath added a comment.
We are still using VS2013 at the moment, but we have started to investigate the
possibility of migrating to 2015. I can report back when I know more, but I
would leave the thread_local keyword out for now.
http://reviews.llvm.org/D16722
__
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks fine. Zach: I don't believe that Mac supports the thread local keywords
correctly yet, but I can check on that. We would need to get the OK from
multiple people (MacOSX, Windows, Fre
zturner added inline comments.
Comment at: source/Core/Timer.cpp:68
@@ -64,1 +67,3 @@
{
+static lldb::thread_key_t g_key =
Host::ThreadLocalStorageCreate(ThreadSpecificCleanup);
+
What did we decide about the C++11 `thread_local` keyword? I know it's been
labath created this revision.
labath added reviewers: clayborg, zturner, tberghammer.
labath added a subscriber: lldb-commits.
I've run into an issue when running unit tests, where the underlying problem
turned out to be
that we were creating Timer objects (through several layers of indirection)
