This revision was automatically updated to reflect the committed changes.
Closed by commit rL258414: Enable test log collection from remote debug servers
(authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D16322?vs=45273&id=45553#toc
Repository:
rL LLVM
http://reviews.ll
tfiala added inline comments.
Comment at: packages/Python/lldbsuite/test/lldbtest.py:1385-1386
@@ +1384,4 @@
+# This is executed on a best-effort basis. If the file is not
there, so be it.
+lldb.remote_platform.Get(lldb.SBFileSpec("server.log"),
+
labath added inline comments.
Comment at: packages/Python/lldbsuite/test/lldbtest.py:1385-1386
@@ +1384,4 @@
+# This is executed on a best-effort basis. If the file is not
there, so be it.
+lldb.remote_platform.Get(lldb.SBFileSpec("server.log"),
+
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
Looks reasonable.
I added one question on whether we can get a warning on failure to retrieve the
server.log file when expecting one and it doesn't show up (perhaps only in
verbose mode), whi
tfiala added a comment.
Oops, this one slipped past me. Looking now!
http://reviews.llvm.org/D16322
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added a comment.
Any thoughts? Objections? Indifference? :)
http://reviews.llvm.org/D16322
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath created this revision.
labath added a reviewer: tfiala.
labath added a subscriber: lldb-commits.
We already have the ability to collect the server logs when doing local
debugging. This enables
the collection of remote logs as well. This relies on specifying a relative
path "server.log" fo
