Re: [Lldb-commits] [PATCH] D16284: Fix Makefile build

2016-09-21 Thread Eugene Zelenko via lldb-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r259081. https://reviews.llvm.org/D16284 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

Re: [Lldb-commits] [PATCH] D16284: Fix Makefile build

2016-01-28 Thread Hans Wennborg via lldb-commits
hans added a comment. I've committed the patch to 3.8 in r259081. Please confirm if this fixes the issue there. http://reviews.llvm.org/D16284 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

Re: [Lldb-commits] [PATCH] D16284: Fix Makefile build

2016-01-28 Thread Keno Fischer via lldb-commits
loladiro added a comment. Sorry I've been away. No this didn't make it in before the Makefiles were removed from trunk. What would you prefer we do? http://reviews.llvm.org/D16284 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lis

Re: [Lldb-commits] [PATCH] D16284: Fix Makefile build

2016-01-28 Thread Hans Wennborg via lldb-commits
hans added a comment. loladiro: Ping? http://reviews.llvm.org/D16284 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D16284: Fix Makefile build

2016-01-26 Thread Hans Wennborg via lldb-commits
hans added a comment. Did this ever get committed? http://reviews.llvm.org/D16284 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D16284: Fix Makefile build

2016-01-19 Thread Hans Wennborg via lldb-commits
hans added a comment. In http://reviews.llvm.org/D16284#329161, @loladiro wrote: > The Makefile system will be removed from trunk very soon, so it might not > necessarily make sense there, but I think it would be good to get this > applied to release-38. @clayborg @hans how would you like to ha

Re: [Lldb-commits] [PATCH] D16284: Fix Makefile build

2016-01-18 Thread Keno Fischer via lldb-commits
loladiro accepted this revision. loladiro added subscribers: clayborg, hans. loladiro added a comment. This revision is now accepted and ready to land. LGTM. The Makefile system will be removed from trunk very soon, so it might not necessarily make sense there, but I think it would be good to ge

Re: [Lldb-commits] [PATCH] D16284: Fix Makefile build

2016-01-17 Thread Isaiah via lldb-commits
ihnorton updated this revision to Diff 45147. ihnorton added a comment. Only build Apple-specific simulators on Darwin, as in r252205 http://reviews.llvm.org/D16284 Files: Makefile source/Plugins/Platform/MacOSX/Makefile Index: source/Plugins/Platform/MacOSX/Makefile ==

[Lldb-commits] [PATCH] D16284: Fix Makefile build

2016-01-17 Thread Isaiah via lldb-commits
ihnorton created this revision. ihnorton added a reviewer: loladiro. ihnorton added a subscriber: lldb-commits. - `source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm` was not matched by the default target, causing link errors. Update Makefile to match r252205. - `test/Mak