This revision was automatically updated to reflect the committed changes.
Closed by commit rL257342: Fix TestMiniDump.py for Python 2/3 (and for a change
to debug info) (authored by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D16017?vs=44385&id=44518#toc
Repository:
rL LLVM
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
In http://reviews.llvm.org/D16017#323550, @amccarth wrote:
> In http://reviews.llvm.org/D16017#322830, @zturner wrote:
>
> > What's the extra frame? Why does Python have an effect on the num
amccarth added a comment.
In http://reviews.llvm.org/D16017#322830, @zturner wrote:
> What's the extra frame? Why does Python have an effect on the number of
> frames seen by the minidump? Something seems wrong about that.
Sorry, I misspoke. It has nothing to do with the version of Python.
What's the extra frame? Why does Python have an effect on the number of
frames seen by the minidump? Something seems wrong about that.
On Fri, Jan 8, 2016 at 3:41 PM Adrian McCarthy wrote:
> amccarth created this revision.
> amccarth added a reviewer: zturner.
> amccarth added a subscriber: ll
amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
Under Python 3, lldb sees an extra frame on the stack, so I check that the
stack has at least the number frames we expect.
Python 3 doesn't have dict.iteritems(). I used a wrapper func
